[MOO-2069] Generate EditableImageValue for native images with allowUpload set to true#175
Open
saurabhchavan1711 wants to merge 3 commits intomendix:masterfrom
Conversation
mlaponder
requested changes
Apr 28, 2026
| if (prop.$.allowUpload === "true") { | ||
| return isNative ? "EditableImageValue<NativeImage>" : "EditableImageValue<WebImage>"; | ||
| } | ||
| return isNative ? "DynamicValue<NativeImage>" : "DynamicValue<WebImage>"; |
Collaborator
There was a problem hiding this comment.
I think it would improve readability if we rewrite this a bit, e.g.
const imageType = isNative ? "NativeImage" : "WebImage";
return `${prop.$.allowUpload === "true" ? "EditableImageValue" : "DynamicValue"}<${imageType}>`;
| ### Added | ||
|
|
||
| - We added support for the `allowUpload` attribute on image properties in native widgets, generating `EditableImageValue<NativeImage>` when enabled. | ||
|
|
Collaborator
There was a problem hiding this comment.
Could you add in which Mendix version this was introduced and also update the version in the package.json of the pluggable widget tools?
Author
There was a problem hiding this comment.
Done . I have updated the changelog and version in package.json to 11.11.0 as this is the Studio Pro version I see when downloading it from the Jenkins pipeline artifact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅This PR contains
What is the purpose of this PR?
We have integrated allowUpload property for image type for our use case in native signature widget and set its value to true. For it we will have to change the type for it to "EditableImageValue" . Updated the existing test's output accordingly.