fix(StopEvent): assign date when including schedule#1009
Open
runkelcorey wants to merge 4 commits into
Open
Conversation
Member
jzimbel-mbta
left a comment
There was a problem hiding this comment.
I think this looks good overall, but (as you also pointed out in the PR description) I wonder if there's a different way to associate a stop event date with a schedule than Map.put-ing it right on the struct.
Contributor
Author
Agreed. I moved the logic to associate dates and schedules out of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: 🐞 Unhandled stop_events query
start_dateas the schedule date when including schedules instop_eventsqueries. Not assigning the date caused this bugScheduleViewto format dates using a date fieldservice_idas attribute of schedules; this enables (2) and also seems useful for consumers (although I guess it hadn't been needed thus far)How were these changes validated?
StopEventControllerTestto check that the service ids returned by each schedule match the expected service idsWhat questions should reviewers consider?
service_idcould mislead consumers?date_secondsanddaterepresent just enough difference that a bigger refactor would be needed but idk