Default Task tables to OSM property columns#2847
Draft
CollinBeczak wants to merge 1 commit into
Draft
Conversation
Drop `featureId` (now redundant with renamed "OSM ID") and seed the default column set for the Manage Challenge task table and the "Work on Multiple Tasks Together" widget with the OSM properties most commonly inspected in the Task Properties widget: access, osmid, userid, changeset, timestamp. - TaskAnalysisTable: DEFAULT_COLUMNS now includes the `:`-prefixed task-property columns alongside id/status/priority/controls/comments - TaskBundleWidget: explicit showColumns updated for both bundled and unbundled states - TaskAnalysisTable: extract findColumn so the showColumns branch resolves `:`-prefixed task properties (previously only the default branch handled them, so explicit lists silently dropped property cols) - WithConfigurableColumns: handle `:`-prefixed columns when seeding addedColumns from defaults (previously gated behind allColumns[column] which is always false for dynamic property keys)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop
featureId(now redundant with renamed "OSM ID") and seed the default column set for the Manage Challenge task table and the "Work on Multiple Tasks Together" widget with the OSM properties most commonly inspected in the Task Properties widget: access, osmid, userid, changeset, timestamp.:-prefixed task-property columns alongside id/status/priority/controls/comments:-prefixed task properties (previously only the default branch handled them, so explicit lists silently dropped property cols):-prefixed columns when seeding addedColumns from defaults (previously gated behind allColumns[column] which is always false for dynamic property keys)