Skip to content

Emit room error before cleanup of room on js client #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karstenda wants to merge 1 commit into from
+1 −1
Closed

Emit room error before cleanup of room on js client #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/loro-websocket/src/client/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,8 +717,8 @@ export class LoroWebsocketClient {
void this.sendRejoinRequest(roomId, msg.roomId, adaptor, active.room, auth);
} else {
// Remove local room state so client does not auto-retry unless requested
this.cleanupRoom(msg.roomId, msg.crdt);
this.emitRoomStatus(roomId, RoomJoinStatus.Error);
this.cleanupRoom(msg.roomId, msg.crdt);
Comment on lines 719 to +721
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Emit error before cleanup can block immediate rejoin

If an onStatusChange callback attempts to rejoin the room synchronously on RoomJoinStatus.Error, this new ordering emits the status while the room is still registered. join() short-circuits when it sees an active room (activeRooms.get(id) returns truthy), so the callback will get the stale room and no rejoin is issued, even though cleanupRoom runs immediately afterward. This only occurs when clients trigger a rejoin in the status callback, but it makes the documented “caller can rejoin manually” path unreliable. Consider cleaning up before emitting or temporarily allowing join to bypass the existing room in this error path.

Useful? React with 👍 / 👎.

}
break;
}
Expand Down