Feature/bridge integration#339
Merged
islandbitcoin merged 120 commits intoMay 7, 2026
Merged
Conversation
- Changed onChainUsdTxFee to use FractionalCentAmount instead of CentAmount - Removed Math.round() that was losing decimal precision from Ibex API - Updated both main and quickstart GraphQL schemas - Aligns with existing pattern used in LnNoAmountUsdInvoiceFeeProbe
* use customer for cashout liabilties account * remove wallet config
* Onchain Validator with Types * Block usage of Btc denominated mutation & call payOnchain function direct * fix circular dependencies & add unit tests
* feat: add fields to AccountUpgradeRequest * explicit check for truthiness from any type
…-fee-fractional-cents
Map the BankQueryError to a Graphql Error
Defines standard SUCCESS_RESPONSE for graphql that maps to the SuccessPayload
…migration updates
Replace hardcoded brh28/frappe-flash:0.0.4 with ${FRAPPE_TAG:-latest}
so developers can pin versions via env var. Add docker-compose.local.yml
for personal overrides (e.g. bind mounting local frappe-flash-admin) and
wire it into COMPOSE_FILE in .env.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…#279) By default, erpnext should run with the latest version of `frappe-flash`. However, a developer can bind the docker volume to their host to make developer changes to the `frappe-flash-admin` repo Replace hardcoded brh28/frappe-flash:0.0.4 with ${FRAPPE_TAG:-latest} so developers can pin versions via env var. Add docker-compose.local.yml for personal overrides (e.g. bind mounting local frappe-flash-admin) and wire it into COMPOSE_FILE in .env.
- Creates GQL Inputs for Address and Bank Account, which map to ErpNext DocTypes - Splits `BusinessUpgradeRequestInput` into a `ProUpgradeRequest` & `MerchantUpgradeRequest` - Simplifies Validation logic using existing `validator` - Removes automatic upgrades for Pro - set terminalsRequested as an int (validation asserts max of 1) - updates return values with the request id so that it can be later queried/handled
Add new tests
- more robust filters - split ErpNext function calls - fix terminals requested bug
- fix bankBranch return error
…ownership (ENG-281)
According to the new plan we are implementing KYC through Bridge Hosted Links This commit fix the body params and response for initiating KYC with the links
… every bridgeVirtualAccount Id is unique
fix: withdraw and transfer process - Add withdrawal idempotencyKey to bridgeInitiateWithdrawal - Validate withdrawal amount before passing to bridge API
this commit is about : - checking kyc status - initiate the kyc through specific resolver - waiting the KYC approval then create automatically the virtual account - query the bridge virtual account for an account
…to feature/bridge-integration # Conflicts: # dev/config/base-config.yaml # package.json # src/app/offers/Validations.ts # src/config/schema.types.d.ts # src/domain/accounts/index.types.d.ts # src/domain/shared/MoneyAmount.ts # src/graphql/error-map.ts # src/graphql/public/queries.ts # src/graphql/public/root/mutation/bridge-add-external-account.ts # src/graphql/public/root/mutation/bridge-create-virtual-account.ts # src/graphql/public/root/mutation/bridge-initiate-kyc.ts # src/graphql/public/root/mutation/bridge-initiate-withdrawal.ts # src/graphql/public/root/query/bridge-virtual-account.ts # src/graphql/public/types/object/bridge-virtual-account.ts # src/servers/bridge-webhook-server.ts # src/servers/graphql-admin-server.ts # src/services/bridge/client.ts # src/services/bridge/errors.ts # src/services/bridge/index.ts # src/services/bridge/webhook-server/middleware/verify-signature.ts # src/services/bridge/webhook-server/routes/kyc.ts # src/services/ibex/client.ts # src/services/ibex/types.ts # src/services/ibex/webhook-server/routes/crypto-receive.ts # src/services/mongoose/accounts.ts # src/services/mongoose/bridge-accounts.ts # src/services/mongoose/schema.ts # src/services/mongoose/schema.types.d.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up - to - date the feature/bridge-integration with the latest works.