[Minor] logging fixes#899
Open
siddimore wants to merge 1 commit intolivekit:mainfrom
Open
Conversation
1ea8fec to
60262a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Several silent failure paths made it a bit harder to debug and understand the reason while debugging
Changes
engine.go— reconnect backoff: Replaced the dead break (delay > maxReconnectInterval) with a min() clamp. With quadratic growth and maxReconnectCount=10, the break was unreachable (max delay is 24.3s vs 60s cap). If maxReconnectCount were ever increased, the break would exit the loop early and skip the OnDisconnected call, leaving the room in a zombie state.engine.go— data packet parse error: Was silently returning on error. Now logs Warnw with the errorengine.go— unknown DataChannel label: Was silently returning. Now logs Warnw with the labelremoteparticipant.go— track subscription timeout: The 5s metadata wait goroutine now logs Warnw with trackSIDlocalparticipant.go— wrong logger instance: updateSubscriptionPermissionLocked was using the global logger instead of p.logTesting
go build . passes cleanly