fix(dock): fix hover bottom border invisible for non-active app items#1622
Merged
deepin-bot[bot] merged 1 commit intoJun 8, 2026
Merged
Conversation
When AppItemBackground overrides outsideBorderColor from the base class, the hovered state was incorrectly set to :normal, causing non-active app items to use the normal color (transparent) on hover - making the bottom border completely invisible. Unify outsideBorderColor with the same palette definition as activeOutsideBorderColor to ensure hover state has dedicated visible color values. AppItemBackground子类覆盖基类outsideBorderColor时,hovered状态 错误地设为:normal,导致非活跃应用的hover底边使用normal色 (transparent)而完全不可见。将outsideBorderColor统一为与 activeOutsideBorderColor相同的完整palette定义,使hover态有独立的 可见颜色值。 Log: 修复任务栏非活跃应用hover底边描边不可见的问题 PMS: BUG-364205 Influence: 仅影响任务栏应用图标hover底边效果,非活跃应用hover时底边描边恢复正常显示,不影响托盘等其他组件。
Reviewer's GuideAdjusts the dock AppItemBackground outside border palette so non-active app items show a visible bottom border on hover, with distinct colors for normal, hovered, and pressed states and dark variants. State diagram for dock AppItemBackground hover border palettestateDiagram-v2
state AppItemBackground {
[*] --> normal
normal --> hovered : mouseHover
hovered --> pressed : mousePress
pressed --> normal : mouseRelease
state normal {
[*] --> normalEfficient
normalEfficient : displayMode = Dock.Efficient
normalTransparent : displayMode != Dock.Efficient
}
state hovered {
hoveredVisible : outsideBorderColor.crystal = rgba(0,0,0,0.10)
}
state pressed {
pressedVisible : outsideBorderColor.crystal = rgba(0,0,0,0.10)
}
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The outsideBorderColor and activeOutsideBorderColor palettes now have very similar hard-coded RGBA values; consider extracting shared constants or a helper to avoid divergence and make future palette tuning easier.
- The new RGBA values (0.1/0.05 alpha) for hover/pressed states in Efficient mode are currently magic numbers; adding a brief inline comment or referencing the design token they come from would make the intent of these specific opacities clearer for future adjustments.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The outsideBorderColor and activeOutsideBorderColor palettes now have very similar hard-coded RGBA values; consider extracting shared constants or a helper to avoid divergence and make future palette tuning easier.
- The new RGBA values (0.1/0.05 alpha) for hover/pressed states in Efficient mode are currently magic numbers; adding a brief inline comment or referencing the design token they come from would make the intent of these specific opacities clearer for future adjustments.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
18202781743
approved these changes
Jun 8, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, Ivy233 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
|
This pr force merged! (status: blocked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When AppItemBackground overrides outsideBorderColor from the base class, the hovered state was incorrectly set to :normal, causing non-active app items to use the normal color (transparent) on hover - making the bottom border completely invisible. Unify outsideBorderColor with the same palette definition as activeOutsideBorderColor to ensure hover state has dedicated visible color values.
AppItemBackground子类覆盖基类outsideBorderColor时,hovered状态 错误地设为:normal,导致非活跃应用的hover底边使用normal色
(transparent)而完全不可见。将outsideBorderColor统一为与
activeOutsideBorderColor相同的完整palette定义,使hover态有独立的 可见颜色值。
Log: 修复任务栏非活跃应用hover底边描边不可见的问题
PMS: BUG-364205
Influence: 仅影响任务栏应用图标hover底边效果,非活跃应用hover时底边描边恢复正常显示,不影响托盘等其他组件。
Summary by Sourcery
Bug Fixes: