ci: ansible-lint requires dependencies to be installed [citest_skip]

[richm]

ansible-lint requires the dependencies in meta/collection-requirements.yml
and tests/collection-requirements.yml to be installed. tox-lsr 3.18.1
will ensure they are installed.

Refactor the tests somewhat so that the collection and test steps are separate.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use tox-lsr 3.18.1 and separate Ansible collection conversion from lint and test execution steps.

CI:

• Bump tox-lsr version from 3.18.0 to 3.18.1 across all GitHub Actions workflows.
• Split ansible-lint and ansible-test workflows into distinct steps for collection conversion and lint/test runs to better handle collection dependencies.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.18.1 and refactors ansible lint/test jobs so collection conversion runs as a separate tox environment before ansible-lint and ansible-test, aligning with new dependency handling requirements.

Flow diagram for refactored ansible-lint CI job

flowchart TD
  A[Start ansible-lint job] --> B[Checkout repository]
  B --> C[Set up Python using matrix versions]
  C --> D[Install tox and tox-lsr 3.18.1 via pip]
  D --> E[Run tox -e collection
Convert role to collection format
Install collection dependencies]
  E --> F[Set ansible-lint and ansible-core versions via LSR_ANSIBLE_LINT_DEP and LSR_ANSIBLE_LINT_ANSIBLE_DEP]
  F --> G[Run tox -e ansible-lint-collection
Execute ansible-lint against converted collection]
  G --> H[Job completed]

Loading

File-Level Changes

Change	Details	Files
Upgrade tox-lsr version used in all CI workflows to 3.18.1.	Bump tox-lsr pip install reference from 3.18.0 to 3.18.1 in ansible-lint workflow. Bump tox-lsr pip install reference from 3.18.0 to 3.18.1 in ansible-test workflow. Bump tox-lsr pip install reference from 3.18.0 to 3.18.1 in ansible-managed-var-comment workflow. Bump tox-lsr pip install reference from 3.18.0 to 3.18.1 in python-unit-test workflow. Bump tox-lsr pip install reference from 3.18.0 to 3.18.1 in qemu-kvm-integration-tests workflow.	.github/workflows/ansible-lint.yml .github/workflows/ansible-test.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/python-unit-test.yml .github/workflows/qemu-kvm-integration-tests.yml
Refactor ansible-lint and ansible-test workflows to run collection conversion and test/lint steps as separate tox environments.	Split combined 'Convert role to collection format and run ansible-lint' step into a 'Convert role to collection format' step running 'tox -e collection' and a 'Run ansible-lint' step running only the ansible-lint tox environment, while preserving environment variables and basepython override. Split combined 'Convert role to collection format and run ansible-test' step into a 'Convert role to collection format' step running 'tox -e collection' and a 'Run ansible-test' step running only the ansible-test tox environment, while preserving the basepython override and matrix-driven ansible version.	.github/workflows/ansible-lint.yml .github/workflows/ansible-test.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}