Skip to content

ideogram4: support circular RoPE#1627

Open
stduhpf wants to merge 1 commit into
leejet:masterfrom
stduhpf:id4-circ
Open

ideogram4: support circular RoPE#1627
stduhpf wants to merge 1 commit into
leejet:masterfrom
stduhpf:id4-circ

Conversation

@stduhpf

@stduhpf stduhpf commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Ideogram4 Ropes Id were not affected by circular_x_enabledor circular_y_enabled, causing it to generate identical latents with or without the --circularflag (only the VAE decoding is tiled).

This PR enables circular RoPE ids for Ideogram4 DiT.

Related Issue / Discussion

N/A

Additional Information

{"high_level_description":"A majestic 360-degree equirectangular HDRI panorama of a grand concert hall interior, designed for VR immersion with a centered horizon and seamless wrapping.","style_description":{"aesthetics":"Opulent, cinematic, and awe-inspiring. The atmosphere is one of grandeur, featuring dramatic highlights and soft ambient glows.","lighting":"High Dynamic Range (HDR) lighting with warm spotlights illuminating the stage, flickering candlelight from chandeliers, and soft reflected light from gold leaf surfaces.","medium":"","art_style":"Photorealistic architecture"},"compositional_deconstruction":{"background":"A vast, symmetrical concert hall with a polished dark wood floor and marble accents. The walls are lined with ornate acoustic panels and gold-trimmed balconies. The ceiling features a complex coffered design with integrated gold leafing.","elements":[{"type":"obj","bbox":[400,300,600,700],"desc":"A wide, polished wooden stage at the center of the hall, slightly elevated, featuring a few empty chairs and a grand piano.","color_palette":["#4E352F","#2C1E1B"]},{"type":"obj","bbox":[500,0,900,400],"desc":"Rows of tiered seating with plush red velvet chairs and brass railings on the left side of the hall.","color_palette":["#8B0000","#D4AF37"]},{"type":"obj","bbox":[500,600,900,1000],"desc":"Rows of tiered seating with plush red velvet chairs and brass railings on the right side of the hall, mirroring the left.","color_palette":["#8B0000","#D4AF37"]},{"type":"obj","bbox":[0,300,300,700],"desc":"An ornate ceiling featuring a massive crystal chandelier and intricate gold leaf carvings, showing the characteristic vertical stretching of an equirectangular projection.","color_palette":["#FFF5E1","#D4AF37"]},{"type":"obj","bbox":[0,0,1000,1000],"desc":"The 360-degree seam where the image wraps horizontally, maintaining a consistent horizon line at the vertical midpoint."}]}}

no circular circularx (master) circularx (PR)
output - Copy (315) output - Copy (313) output - Copy (314)
rolled rolled rolled

{"high_level_description":"A sprawling, dense metropolis captured from a high-altitude isometric perspective, showcasing a labyrinth of skyscrapers, neon-lit highways, and organized urban greenery.","style_description":{"aesthetics":"Cinematic, vibrant, and highly detailed with a sense of immense scale.","lighting":"Golden hour sunlight casting long, soft shadows and a warm glow across the glass facades.","medium":"","art_style":"Stylized architectural visualization with a distinct isometric tilt."},"compositional_deconstruction":{"background":"A hazy, atmospheric horizon where the urban sprawl meets a distant coastal bay and soft mountain peaks.","elements":[{"type":"obj","bbox":[100,200,900,800],"desc":"A dense cluster of glass and steel skyscrapers of varying heights, featuring intricate architectural details and lit windows.","color_palette":["#bdc3c7","#34495e"]},{"type":"obj","bbox":[400,0,700,1000],"desc":"A network of multi-lane highways and winding roads weaving through the city blocks, populated by thousands of tiny, colorful vehicles.","color_palette":["#2c3e50","#e67e22"]},{"type":"obj","bbox":[350,300,650,700],"desc":"Lush green urban parks and public plazas interspersed between the buildings, featuring small trees and walking paths.","color_palette":["#27ae60","#2ecc71"]},{"type":"obj","bbox":[0,0,300,1000],"desc":"A shimmering blue bay at the edge of the city, with small docks and white foam near the shoreline.","color_palette":["#3498db","#aed6f1"]}]}}

no circular circular (master) circular (PR)
output - Copy (316) output output - Copy (317)
rolled rolled rolled

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant