fix(ui): fix dark text in dark mode for carrer page#7655
Open
AyushK5ingh wants to merge 1 commit intolayer5io:masterfrom
Open
fix(ui): fix dark text in dark mode for carrer page#7655AyushK5ingh wants to merge 1 commit intolayer5io:masterfrom
AyushK5ingh wants to merge 1 commit intolayer5io:masterfrom
Conversation
Signed-off-by: ayushk5ingh <ayushks1602@gmail.com>
Contributor
|
🚀 Preview deployment: https://layer5.io/pr-preview/pr-7655/
|
rishiraj38
reviewed
Apr 23, 2026
Member
rishiraj38
left a comment
There was a problem hiding this comment.
Please add the reference image before and after.
Member
|
@AyushK5ingh , I checked the page link, but I couldn’t see this issue on my side. The text looks white on the dark background and seems fine. Could you share more details or a screenshot if the issue is still happening? |
Contributor
Author
|
I doesn't reproduce like that. It occurs when u bavigate through website to that page then it make transition sort of animation to black |
Contributor
Author
|
before with after at end Screen.Recording.2026-04-24.133124.mp4after Screen.Recording.2026-04-24.132821.mp4before is not consistent somehow. but majority of time it is reproducing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #7653.
Previously, certain text elements on the Careers page remained dark when toggling dark mode, resulting in poor visibility. This PR resolves the issue by updating
src/collections/careers/Career.style.jsto use the dynamic theme color variable (whiteSevenFiveToBlackSevenFive) for paragraphs, list items, and footer text elements.Additionally, smooth cubic-bezier transitions (
0.8s cubic-bezier(0.2, 0.8, 0.2, 1)) were added to these elements to ensure a fluid visual change when the user toggles the theme.Notes for Reviewers
Signed commits