Skip to content

fix(ui): fix dark text in dark mode for carrer page#7655

Open
AyushK5ingh wants to merge 1 commit intolayer5io:masterfrom
AyushK5ingh:issue#7653
Open

fix(ui): fix dark text in dark mode for carrer page#7655
AyushK5ingh wants to merge 1 commit intolayer5io:masterfrom
AyushK5ingh:issue#7653

Conversation

@AyushK5ingh
Copy link
Copy Markdown
Contributor

Description

This PR fixes #7653.

Previously, certain text elements on the Careers page remained dark when toggling dark mode, resulting in poor visibility. This PR resolves the issue by updating src/collections/careers/Career.style.js to use the dynamic theme color variable (whiteSevenFiveToBlackSevenFive) for paragraphs, list items, and footer text elements.

Additionally, smooth cubic-bezier transitions (0.8s cubic-bezier(0.2, 0.8, 0.2, 1)) were added to these elements to ensure a fluid visual change when the user toggles the theme.

Notes for Reviewers

  • Navigate to the Careers page and toggle between light and dark modes.
  • Verify that the text inside the body sections, qualifications list, and job details footer now properly adapts to the dark theme and is fully legible.
  • Observe the smooth transition effect during the theme switch.
    Signed commits
  • Yes, I signed my commits.

Signed-off-by: ayushk5ingh <ayushks1602@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Preview deployment: https://layer5.io/pr-preview/pr-7655/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

Copy link
Copy Markdown
Member

@rishiraj38 rishiraj38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the reference image before and after.

@Sbragul26
Copy link
Copy Markdown
Member

@AyushK5ingh , I checked the page link, but I couldn’t see this issue on my side. The text looks white on the dark background and seems fine. Could you share more details or a screenshot if the issue is still happening?

@AyushK5ingh
Copy link
Copy Markdown
Contributor Author

I doesn't reproduce like that. It occurs when u bavigate through website to that page then it make transition sort of animation to black

@AyushK5ingh
Copy link
Copy Markdown
Contributor Author

AyushK5ingh commented Apr 24, 2026

before with after at end

Screen.Recording.2026-04-24.133124.mp4

after

Screen.Recording.2026-04-24.132821.mp4

before is not consistent somehow. but majority of time it is reproducing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] font colour mismatch in dark mode

3 participants