YNU-864: Harness rule cleanup#151
Merged
ihsraham merged 1 commit intodocs/reorg-for-v1from May 8, 2026
Merged
Conversation
Tightens six pre-promotion issues in the language harness from #150: - Disable NoMetaphor/SpecVoice/NoNarrative/cross-link/BuildPageShape rules by default; overlays opt in. - Narrow AISlop.harness to verbal context so the noun usage stops triggering. - Drop NeedBasedLabels catch-all; keep explicit token list. - Split BuildPageShape into four heading-specific error-level rules. - Add LearnCrossLink and ProtocolCrossLink rule files (disabled by default; activated per-overlay). - Remove non-directional CrossLink.yml.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #150 that tightens the docs language harness before it is promoted from advisory to blocking.
What changed
AISlopharnesstoken to verbal context, so noun usage like "language harness" does not trigger.NeedBasedLabelscatch-all and kept the explicit internal-label examples.BuildPageShaperule with four distinct heading-specific error-level rules.LearnCrossLinkandProtocolCrossLinkrules, both disabled by default until overlays activate them.CrossLink.ymlrule.Context
The original harness skeleton landed in #150. This cleanup follows the language harness PRD at
ynu-864-yellow-docs-v1-review/05-language-harness-prd.md, especially sections 5, 6, 7, 9, and 11.Validation
vale ls-config 2>&1 | grep -i "BuildPageShape"shows four distinct rule names:BuildPageShapeTLDR,BuildPageShapeStepByStep,BuildPageShapeVerify, andBuildPageShapeNextSteps.vale --minAlertLevel=error templatesreturns 0 findings.vale --minAlertLevel=error docs | tail -20still shows the existing 71 docs findings from YNU-864: Add language harness skeleton #150-era advisory mode; this PR does not change docs content.npm run build 2>&1 | tail -10succeeds with the same existing 0.5.x broken-link/anchor warning tail.git diff --checkpasses.