feat: add more hud settings#192
Merged
Merged
Conversation
Member
|
Looks good, but sameLine() still gets called even when showKeybind is disabled, resulting in all modules being placed on the same line |
beanbag44
requested changes
Dec 15, 2025
beanbag44
left a comment
beanbag44
left a comment
Member
There was a problem hiding this comment.
looks good, just the formatting for sameLine seems off. Thats all though
Contributor
Author
|
wtf it looked fine on my phone, never using github there |
Contributor
|
Could you use a LimitedDecayQueue for the average fps count? Could you also use monotonic kotlin times instead of longs? |
Contributor
Author
|
LimitedDecayQueue uses millis so theres no point of using it in that case |
Contributor
I meant to use the queue to store nanos, either way it shouldnt really matter for the accuracy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added following setting to hud modules:
Show KeybindtoModuleListAveragetoFPS