Deprecate validate_properties_on_set=False#341
Merged
Conversation
Previously, we raised a DeprecationWarning when this key wasn't specified. I've upgraded that to raise it if the key isn't true.
Barecheck - Code coverage reportTotal: 96.86%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
julianstirling
approved these changes
May 13, 2026
Contributor
julianstirling
left a comment
julianstirling
left a comment
There was a problem hiding this comment.
This certainly is true for settings as if they are unvalidated then there are issues when they are written/read from json. I think this makes sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we raised a DeprecationWarning when this key wasn't specified. I've upgraded that to raise it if the key isn't true.
This is motivated by realising that validating properties on write is really the only sensible
option: they are already validated on read as a consequence of how they are serialized.