Skip to content

chore: remove windows-arm from release template#888

Merged
mbevc1 merged 1 commit into
mainfrom
20260512_no_win_arm
May 12, 2026
Merged

chore: remove windows-arm from release template#888
mbevc1 merged 1 commit into
mainfrom
20260512_no_win_arm

Conversation

@mbevc1
Copy link
Copy Markdown
Contributor

@mbevc1 mbevc1 commented May 12, 2026

We don't produce artifacts for Windows Arm: https://github.com/kosli-dev/cli/blob/main/.goreleaser.yml#L28-L30

Let's make this Trail compliant again 😄

@mbevc1 mbevc1 enabled auto-merge (squash) May 12, 2026 15:27
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 12, 2026

Claude finished @mbevc1's task in 1m 25s —— View job


PR Review: Remove windows-arm from release template

  • Gather context and read changed files
  • Run static analysis checks (go build, go vet, go mod tidy — all pass)
  • Review changes
  • Post final review

Verdict: Looks good

The windows-arm artifact entry in release-flow-template.yml has no corresponding build target — .goreleaser.yml explicitly ignores goos: windows + goarch: arm (lines 29-30). Removing it from the flow template is the correct fix to make the trail compliant.

I verified:

  • The GoReleaser config confirms windows/arm is in the ignore list
  • No other references to windows-arm (distinct from windows-arm64) remain in the codebase
  • windows-arm64 and windows-amd64 entries are correctly preserved
  • Static analysis all clean — go build, go vet, and go mod tidy pass with no issues

Nice catch on the template/build mismatch — clean one-line fix.

@mbevc1 mbevc1 merged commit 5e3b640 into main May 12, 2026
16 checks passed
@mbevc1 mbevc1 deleted the 20260512_no_win_arm branch May 12, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants