Skip to content

MIDI file playback support#56

Open
ishland wants to merge 13 commits into
koca2000:masterfrom
ishland:feature/midi-player
Open

MIDI file playback support#56
ishland wants to merge 13 commits into
koca2000:masterfrom
ishland:feature/midi-player

Conversation

@ishland

@ishland ishland commented Aug 23, 2020

Copy link
Copy Markdown
Contributor

Closes #24

@ishland ishland marked this pull request as ready for review January 2, 2021 14:20
@ishland ishland changed the title [WIP] Full-precision midi support MIDI file playback support Jan 2, 2021
@mibby

mibby commented Feb 2, 2021

Copy link
Copy Markdown

Is this currently implemented in any player for testing or just API additions for future use?

Edit: Assuming not yet, but if @koca2000 can merge the PR (if it's ready), MusicBox plugin would be one of the first to implement testing support once merged.

@ishland

ishland commented Feb 4, 2021

Copy link
Copy Markdown
Contributor Author

Is this currently implemented in any player for testing or just API additions for future use?

It is currently implemented and works just fine in my testings.
Currently theres are still some apis which is not working when playing midi files but I am working on it.

@mibby

mibby commented Feb 5, 2021

Copy link
Copy Markdown

I was just more curious if there was a front-end player that supported the API changes already. When I did some testing, various plugins (such as MusicBox) seemed to break due to API changes, so I'll probably just wait until it's merged into the main branch before testing midi support again.

@ishland

ishland commented Feb 5, 2021

Copy link
Copy Markdown
Contributor Author

I was just more curious if there was a front-end player that supported the API changes already. When I did some testing, various plugins (such as MusicBox) seemed to break due to API changes, so I'll probably just wait until it's merged into the main branch before testing midi support again.

I got a modified JukeBox plugin here.
jukebox.zip

@koca2000

koca2000 commented Feb 5, 2021

Copy link
Copy Markdown
Owner

I was just more curious if there was a front-end player that supported the API changes already. When I did some testing, various plugins (such as MusicBox) seemed to break due to API changes, so I'll probably just wait until it's merged into the main branch before testing midi support again.

Hi! This is just one of the possible variants of implementation. The final change won't break other plugins.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
8.2% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MIDI support

3 participants