Skip to content

🧪 [testing] add unit tests for normalizeInstr#35

Open
julesklord wants to merge 1 commit into
mainfrom
testing-normalize-instr-13315948952698931644
Open

🧪 [testing] add unit tests for normalizeInstr#35
julesklord wants to merge 1 commit into
mainfrom
testing-normalize-instr-13315948952698931644

Conversation

@julesklord
Copy link
Copy Markdown
Owner

I have added unit tests for the normalizeInstr function to improve the reliability and coverage of the codebase.

🎯 What

Addressed the testing gap for the normalizeInstr utility function which is responsible for mapping various instrument names to internal codes.

📊 Coverage

The new tests cover the following scenarios:

  • Edge cases: null, undefined, strings, objects, and empty arrays (all default to ['g']).
  • Mapping: Correctly maps synonyms like 'guitarra' to 'g', 'keyboards' to 'p', 'horns' to 'v', etc.
  • Codes: Accepts existing internal codes ('g', 'p', 'v', 'o').
  • Normalization: Handles case-insensitivity ('GUITAR') and leading/trailing spaces (' Vocals ').
  • Deduplication: Removes duplicate codes if multiple input names map to the same code.
  • Validation: Filters out unrecognized instrument names.
  • Defaulting: Returns ['g'] if no valid instruments remain after filtering.

✨ Result

  • Improved test coverage for core utility functions.
  • Increased confidence in instrument normalization logic during CSV imports and song creation.
  • All 33 automated tests are passing.

PR created automatically by Jules for task 13315948952698931644 started by @julesklord

- Export `normalizeInstr` from `js/app.js` for testing.
- Implement comprehensive unit tests in `tests/run-tests.js` covering:
  - Non-array and empty inputs (defaulting to ['g']).
  - Instrument name mapping to internal codes.
  - Case-insensitivity and whitespace handling.
  - Duplicate removal.
  - Filtering of invalid instruments.
- Verified all tests pass with `npm test`.

Co-authored-by: julesklord <801266+julesklord@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant