🧪 [testing] add unit tests for normalizeInstr#35
Conversation
- Export `normalizeInstr` from `js/app.js` for testing. - Implement comprehensive unit tests in `tests/run-tests.js` covering: - Non-array and empty inputs (defaulting to ['g']). - Instrument name mapping to internal codes. - Case-insensitivity and whitespace handling. - Duplicate removal. - Filtering of invalid instruments. - Verified all tests pass with `npm test`. Co-authored-by: julesklord <801266+julesklord@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
I have added unit tests for the
normalizeInstrfunction to improve the reliability and coverage of the codebase.🎯 What
Addressed the testing gap for the
normalizeInstrutility function which is responsible for mapping various instrument names to internal codes.📊 Coverage
The new tests cover the following scenarios:
null,undefined, strings, objects, and empty arrays (all default to['g']).['g']if no valid instruments remain after filtering.✨ Result
PR created automatically by Jules for task 13315948952698931644 started by @julesklord