Make the log level for the request middleware fully configurable#1024
Open
offbyone wants to merge 1 commit intojrobichaud:mainfrom
Open
Make the log level for the request middleware fully configurable#1024offbyone wants to merge 1 commit intojrobichaud:mainfrom
offbyone wants to merge 1 commit intojrobichaud:mainfrom
Conversation
offbyone
force-pushed
the
push-tkpuvxrrvkvu
branch
3 times, most recently
from
10a7c08 to
5a88e67
Compare
This was referenced Apr 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1024 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 51 51
Lines 2228 2272 +44
Branches 35 36 +1
=========================================
+ Hits 2228 2272 +44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jrobichaud
requested changes
Apr 30, 2026
Owner
jrobichaud
left a comment
jrobichaud
left a comment
There was a problem hiding this comment.
Please remove the uv.lock.
Also fix the coverage and linter issues.
- adds `STATUS_DEFAULT_LOG_LEVEL`, `STATUS_START_LOG_LEVEL`, and `STATUS_2XX_LOG_LEVEL` app settings - adds `CELERY_DEFAULT_LOG_LEVEL`, `CELERY_TASK_START_LOG_LEVEL`, `CELERY_TASK_SUCCESS_LOG_LEVEL`, `CELERY_TASK_NOTICE_LOG_LEVEL`, `CELERY_TASK_FAILURE_LOG_LEVEL`, `CELERY_TASK_ERROR_LOG_LEVEL` - uses settings to determine the log level for all non-exception path logging in the request middleware Fixes jrobichaud#1022
offbyone
force-pushed
the
push-tkpuvxrrvkvu
branch
from
5a88e67 to
1993781
Compare
Author
|
I think it's done -- the tests are really noisy locally, but I think I confirmed this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STATUS_DEFAULT_LOG_LEVEL,STATUS_START_LOG_LEVEL, andSTATUS_2XX_LOG_LEVELapp settingsCELERY_DEFAULT_LOG_LEVEL,CELERY_TASK_START_LOG_LEVEL,CELERY_TASK_SUCCESS_LOG_LEVEL,CELERY_TASK_NOTICE_LOG_LEVEL,CELERY_TASK_FAILURE_LOG_LEVEL,CELERY_TASK_ERROR_LOG_LEVELFixes #1022