Skip to content

Fix: fix pglogrepl.SendStandbyCopyDone#57

Open
zzzzwc wants to merge 1 commit into
jackc:masterfrom
zzzzwc:fix-SendStandbyCopyDone
Open

Fix: fix pglogrepl.SendStandbyCopyDone#57
zzzzwc wants to merge 1 commit into
jackc:masterfrom
zzzzwc:fix-SendStandbyCopyDone

Conversation

@zzzzwc

@zzzzwc zzzzwc commented Aug 3, 2023

Copy link
Copy Markdown

Change the return value '*CopyDoneResult' to struct to avoid NPE when receive a DataRow message.

Change the return value '*CopyDoneResult' to struct to avoid NPE when receive a DataRow message.
@zzzzwc zzzzwc force-pushed the fix-SendStandbyCopyDone branch from b91f3c7 to 864b4b5 Compare August 3, 2023 08:55
@jackc

jackc commented Aug 5, 2023

Copy link
Copy Markdown
Owner

Would it be better to instantiate a CopyDoneResult internally to resolve the bug rather than change the signature of the function? In theory, that's a breaking change... though I suppose no one could be relying on it because the current code crashes... 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants