[SYCL] Enable referencing a kernel from a different translation unit#22264
Open
sergey-semenov wants to merge 5 commits into
Open
[SYCL] Enable referencing a kernel from a different translation unit#22264sergey-semenov wants to merge 5 commits into
sergey-semenov wants to merge 5 commits into
Conversation
Prior to this patch, referencing a kernel from another translation unit via kernel bundle/ID API led to undefined behavior due to usage of KernelInfo specializations from integration headers (which are only provided for the TUs the kernels are provided in). This patch fixes that by using inline friend function definitions that provide symbols with external linkage that the runtime can call to retrieve kernel names from any translation unit. If the user attempts to request a kernel via a kernel name type that doesn't exist, it will now result in an undefined reference error instead of a runtime one.
Contributor
Author
|
Reopen of #22246. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this patch, referencing a kernel from another translation unit
via kernel bundle/ID API led to undefined behavior due to usage of KernelInfo
specializations from integration headers (which are only provided for the TUs
the kernels are provided in). This patch fixes that by using inline friend
function definitions that provide symbols with external linkage that the runtime
can call to retrieve kernel names from any translation unit. If the user attempts
to request a kernel via a kernel name type that doesn't exist,
it will now result in an undefined reference error instead of a runtime one.