WIP: refactor(migtd/migration): drop Service.Query leaf and its tests#889
Draft
sgrams wants to merge 2 commits into
Draft
WIP: refactor(migtd/migration): drop Service.Query leaf and its tests#889sgrams wants to merge 2 commits into
sgrams wants to merge 2 commits into
Conversation
sgrams
force-pushed
the
t7-drop-service-envelope
branch
from
b0677bd to
39145b2
Compare
sgrams
changed the title
The April 2026 GHCI 1.5 revision has no Service.Query sub-function
(Tables 3-42 / 3-45 / 3-52 / 3-59 / 3-62 — only the <MigTD.*> per-API
leaves: WaitForRequest, ReportStatus, Send, Receive). Service.Query
was a February 2026 GHCI 1.5 holdover used to probe VMM support before
any real work; in the April 2026 revision the support check is
implicit in calling MigTD.WaitForRequest itself.
Remove:
* migration::session::query() — the only caller of the Service.Query
envelope path
* ServiceQueryResponse struct and QUERY_COMMAND constant in
migration::data
* tests/test-td-payload's testservice case and its tcs002 entry in
the JSON config
* src/migtd/fuzz service_response and afl_service_response targets
(and their seed corpus) which exclusively exercised the dead
response wrapper
Signed-off-by: Stanislaw Grams <stanislaw.grams@intel.com>
sgrams
force-pushed
the
t7-drop-service-envelope
branch
from
39145b2 to
0388861
Compare
Contributor
Author
|
Deprecation of Service is not required for June release, old APIs are permittable |
…wn leaf scaffolding April 2026 GHCI 1.5 has no MigTD.Shutdown sub-function. session::shutdown() had no callers anywhere in the workspace; it was a legacy holdover from the February 2026 GHCI 1.5 envelope era when WaitForRequest carried a shutdown opcode (operation=0). Removes: * pub fn shutdown() in src/migtd/src/migration/session.rs * pub const MIG_COMMAND_SHUT_DOWN: u8 = 0; in src/migtd/src/migration/data.rs * pub struct ServiceMigWaitForReqShutdown in src/migtd/src/migration/data.rs Second slice of T7 (envelope drop) on branch t7-drop-service-envelope; the remaining envelope users (wait_for_request, report_status, both non-vmcall-raw) are blocked on a real spec gap: the per-leaf MigTD.WaitForRequest response (Table 3-47) carries no slot for vsock peer CID/port or the legacy migpolicy HOB. Migrating them would break virtio-vsock peer discovery and is tracked separately. Signed-off-by: Stanislaw Grams <stanislaw.grams@intel.com>
sgrams
changed the title
sgrams
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHCI 1.5 v6 has no Service.Query sub-function (Tables 3-42 / 3-45 / 3-52 / 3-59 / 3-62 — only the <MigTD.*> per-API leaves: WaitForRequest, ReportStatus, Send, Receive). Service.Query was a v5 holdover used to probe VMM support before any real work; in v6 the support check is implicit in calling MigTD.WaitForRequest itself.
Remove: