Skip to content

Sfp 101 nl#158

Closed
Florian9041 wants to merge 11 commits intomainfrom
sfp-101-nl
Closed

Sfp 101 nl#158
Florian9041 wants to merge 11 commits intomainfrom
sfp-101-nl

Conversation

@Florian9041
Copy link
Copy Markdown
Contributor

@Florian9041 Florian9041 commented Apr 30, 2026

Description

Veldprotocol van project quickscan knijten veldstaalname en laboverwerking. Team estuaria.
PRJ - Knijten - Culicoides onderzoek in het Schelde-estuarium (EVINBO) INBOPRJ-23055

Related Issue

Task list

Steps by contributor:

  • Add description to this pull request (under "## Description")
  • Open the dropdown (triangle) near 'create pull request' and choose 'Create draft pull request'
  • Check for potential problems by running protocolhelper::check_frontmatter() and address them
  • Check for potential problems by running protocolhelper::check_structure() and address them
  • Add further commits if needed and push them to GitHub
  • Update the protocol-specific NEWS.Rmd
  • Mark the pull request as 'ready for review'

Review steps for the author(s):

  • Add reviewers, at least one subject-matter specialist and one administrator
  • Wait for review comments and address them
  • Iterate until reviewer approvals (merging the pull request will be done by an administrator)
  • Verify that the checks done by continuous integration succeeded. These will check if protocolhelper::check_frontmatter() and protocolhelper::check_structure() succeeded without errors.

To be done by an administrator after review: see guidelines for admins.

@Florian9041 Florian9041 self-assigned this Apr 30, 2026
@hansvancalster
Copy link
Copy Markdown
Collaborator

@Florian9041 in deze PR zitten een aantal wijzigingen in bestanden die niet deel uimaken van je protocol (dus in andere map dan source/sfp/1_water/sfp_101_nl_quickscan_knijten_v/. Dit is niet toegelaten en zal door checklist::check_structure() waarschijnlijk gedetecteerd/tegengehouden worden. Ik denk dat we bij gelegenheid best samen eens bekijken hoe dat best ongedaan gemaakt kan worden. Ik denk dat het commit 40cf140 is waar iets misgelopen is.

@Florian9041
Copy link
Copy Markdown
Contributor Author

@hansvancalster mss kan ik mijn branch terugzetten tot 40cf140? Ik heb lokaal wel nog een backup staan met de inhoud.

@Florian9041
Copy link
Copy Markdown
Contributor Author

Hoe kan ik dit doen?

@hansvancalster hansvancalster deleted the sfp-101-nl branch April 30, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants