Skip to content

ci(antipattern): broaden TS allowlist (cli, mod.ts, lsp-server, *vscode*, deno-*) #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 1 commit into from
May 3, 2026
Merged

ci(antipattern): broaden TS allowlist (cli, mod.ts, lsp-server, *vscode*, deno-*) #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions .github/workflows/rsr-antipattern.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,16 @@ jobs:
- name: Check for TypeScript
run: |
# Allowlist (TS legitimate as a bridge/adapter to a non-ReScript ecosystem):
# bindings/ - language bindings (Deno/TS/AssemblyScript FFI to ReScript core)
# *.d.ts - TypeScript type declarations for ReScript FFI
# tests/, test/ - Deno test runners verifying ReScript output
# scripts/ - Deno build scripts (bundle, dev-server, etc.)
# mcp-adapter/ - MCP server adapters (MCP protocol is Deno/TS-typed by spec)
# vscode/ - VSCode extensions (TS is the ecosystem default)
# bindings/ - language bindings (Deno/TS/AssemblyScript FFI)
# *.d.ts - TypeScript type declarations for ReScript FFI
# tests/, test/ - Deno test runners
# scripts/ - Deno build scripts
# mcp-adapter/ - MCP server adapters (MCP is Deno/TS-typed by spec)
# *vscode* - VSCode extensions (TS is the ecosystem default)
# cli/ - CLI entry points (Deno scripts)
# mod.ts - canonical Deno module entrypoint
# *lsp-server.ts, *lsp.ts - Language Server Protocol implementations
# deno-*/ - subprojects explicitly named for Deno
TS_FILES=$(find . \( -name "*.ts" -o -name "*.tsx" \) \
| grep -v node_modules \
| grep -v '/bindings/' \
Expand All @@ -48,7 +52,12 @@ jobs:
| grep -v '/test/' \
| grep -v '/scripts/' \
| grep -v '/mcp-adapter/' \
| grep -v '/vscode/' \
| grep -Ev '/[^/]*vscode[^/]*/' \
| grep -v '/cli/' \
| grep -v '/mod\.ts$' \
| grep -Ev 'lsp[-_]?server\.ts$' \
| grep -Ev '[/-]lsp\.ts$' \
| grep -Ev '/deno-[^/]+/' \
|| true)
if [ -n "$TS_FILES" ]; then
echo "❌ TypeScript files detected - use ReScript instead"
Expand Down
Loading