Skip to content

Pr feedback

45d09f2
Select commit
Loading
Failed to load commit list.
Open

mshv: use VP register page for RIP/RAX writes in run_vcpu #1366

Pr feedback
45d09f2
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Apr 29, 2026 in 1s

DCO

There are 8 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <authoremail@example.com> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~36 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin mshv_use_vp_page

Summary

Commit sha: 17cddf3, Author: Dan Chiarlone, Committer: GitHub; Can not find "Dan Chiarlone danilochiarlone@gmail.com", in ["danbugs danilochiarlone@gmail.com", "Tomasz Andrzejak andreiltd@gmail.com", "Tomasz Andrzejak andreiltd@gmail.com", "Tomasz Andrzejak andreiltd@gmail.com", "danbugs danilochiarlone@gmail.com", "Tomasz Andrzejak andreiltd@gmail.com"].
Commit sha: 2b803de, Author: Dan Chiarlone, Committer: GitHub; Expected "Dan Chiarlone danilochiarlone@gmail.com", but got "danbugs danilochiarlone@gmail.com".
Commit sha: 2fca7ae, Author: Dan Chiarlone, Committer: GitHub; Expected "Dan Chiarlone danilochiarlone@gmail.com", but got "danbugs danilochiarlone@gmail.com".
Commit sha: 6ea9816, Author: Dan Chiarlone, Committer: GitHub; Expected "Dan Chiarlone danilochiarlone@gmail.com", but got "danbugs danilochiarlone@gmail.com".
Commit sha: 94ee495, Author: Dan Chiarlone, Committer: GitHub; Can not find "Dan Chiarlone danilochiarlone@gmail.com", in ["Ludvig Liljenberg 4257730+ludfjig@users.noreply.github.com", "Ludvig Liljenberg 4257730+ludfjig@users.noreply.github.com", "Ludvig Liljenberg 4257730+ludfjig@users.noreply.github.com", "danbugs danilochiarlone@gmail.com", "Tomasz Andrzejak andreiltd@gmail.com", "Tomasz Andrzejak andreiltd@gmail.com", "Ludvig Liljenberg 4257730+ludfjig@users.noreply.github.com", "Ludvig Liljenberg 4257730+ludfjig@users.noreply.github.com", "Ludvig Liljenberg 4257730+ludfjig@users.noreply.github.com", "Ludvig Liljenberg 4257730+ludfjig@users.noreply.github.com", "Ludvig Liljenberg 4257730+ludfjig@users.noreply.github.com", "Ludvig Liljenberg 4257730+ludfjig@users.noreply.github.com", "danbugs danilochiarlone@gmail.com", "Tomasz Andrzejak andreiltd@gmail.com", "danbugs danilochiarlone@gmail.com", "Tomasz Andrzejak andreiltd@gmail.com", "Tomasz Andrzejak andreiltd@gmail.com", "Tomasz Andrzejak andreiltd@gmail.com", "Tomasz Andrzejak andreiltd@gmail.com", "danbugs danilochiarlone@gmail.com", "danbugs danilochiarlone@gmail.com", "danbugs danilochiarlone@gmail.com", "danbugs danilochiarlone@gmail.com", "danbugs danilochiarlone@gmail.com", "danbugs danilochiarlone@gmail.com", "danbugs danilochiarlone@gmail.com", "danbugs danilochiarlone@gmail.com", "danbugs danilochiarlone@gmail.com", "danbugs danilochiarlone@gmail.com", "Tomasz Andrzejak andreiltd@gmail.com", "Ludvig Liljenberg 4257730+ludfjig@users.noreply.github.com"].
Commit sha: cac9f8a, Author: Tomasz Andrzejak, Committer: GitHub; Expected "Tomasz Andrzejak andreiltd@users.noreply.github.com", but got "Tomasz Andrzejak andreiltd@gmail.com".
Commit sha: edd5b67, Author: Tomasz Andrzejak, Committer: GitHub; Expected "Tomasz Andrzejak andreiltd@users.noreply.github.com", but got "Tomasz Andrzejak andreiltd@gmail.com".
Commit sha: 7f6f2bc, Author: Tomasz Andrzejak, Committer: GitHub; Expected "Tomasz Andrzejak andreiltd@users.noreply.github.com", but got "Tomasz Andrzejak andreiltd@gmail.com".