fix: log ignored longcat positional id arguments#13900
Open
wunianze666-netizen wants to merge 1 commit into
Open
fix: log ignored longcat positional id arguments#13900wunianze666-netizen wants to merge 1 commit into
wunianze666-netizen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces direct
print()warnings in the LongCat positional-id helpers with standard logger warnings and fixes theUnknown typeerror message.Problem
prepare_pos_ids()in both LongCat image pipelines currently prints warnings directly to stdout when callers pass ignored arguments. That is noisy for library consumers and harder to capture in tests. The helper also raises aKeyErrorwith a small typo in the message.Changes
print()calls withlogger.warning()in both LongCat image helpersUnknow typetoUnknown typeVerification
python -m py_compile src/diffusers/pipelines/longcat_image/pipeline_longcat_image.py src/diffusers/pipelines/longcat_image/pipeline_longcat_image_edit.py tests/pipelines/longcat_image/test_prepare_pos_ids.pypytestis not available in this environment, so I could not execute the new test locally.