Conversation
Adds JUnit 5, Mockito, Spring Test, and MockMvc for writing controller tests.
Tests use @WebMvcTest with a mocked DataSource to verify: - GET / returns 200 and renders the index view - GET /database returns records from a mocked connection - GET /database returns 500 with error view on connection failure
Adds environments.test to app.json so Heroku CI provisions a PostgreSQL database and runs mvn test automatically.
Spring Boot 4 moved @WebMvcTest to the spring-boot-webmvc-test module. This dependency is required alongside spring-boot-starter-test.
- Use org.springframework.boot.webmvc.test.autoconfigure.WebMvcTest (new package in Spring Boot 4) - Remove status code assertion from error test since MockMvc view rendering resets the status set via HttpServletResponse.setStatus()
In-dyno databases are ephemeral databases that run inside the test dyno, providing faster startup than provisioning a real addon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The buildpack builds the project on Heroku CI already so we know it compiles. This adds tests to validate logic beyond making sure it compiles.