Skip to content

Update Angular integration guide to modern patterns (v20+)#1658

Draft
sequba wants to merge 17 commits intodevelopfrom
claude/review-angular-integration-JaDOF
Draft

Update Angular integration guide to modern patterns (v20+)#1658
sequba wants to merge 17 commits intodevelopfrom
claude/review-angular-integration-JaDOF

Conversation

@sequba
Copy link
Copy Markdown
Contributor

@sequba sequba commented Apr 20, 2026

Context

The Angular integration guide was using outdated patterns (NgModule, RxJS BehaviorSubject, async pipe, OnDestroy lifecycle hook). Angular 20+ has introduced new idiomatic approaches (standalone components, signals, @if/@for control flow, inject(), DestroyRef) that are now the recommended way to build Angular applications.

This update modernizes the documentation to reflect current Angular best practices while maintaining clarity for developers using the library.

Changes

  • Signals instead of RxJS: Replaced BehaviorSubject and Observable with Angular signals for simpler state management and automatic change detection
  • Modern component syntax: Updated examples to use standalone components with @Component decorator and inject() for dependency injection
  • Control flow syntax: Replaced *ngIf and *ngFor with @if and @for built-in control flow
  • Cleanup pattern: Replaced implements OnDestroy / ngOnDestroy() with inject(DestroyRef).onDestroy() callback pattern
  • OnPush change detection: Added ChangeDetectionStrategy.OnPush to the component example for better performance
  • Clarified scope: Updated provider scope explanation to reflect modern terminology
  • Added context note: Included a tip at the end noting that the linked Stackblitz demo uses older patterns and directing readers to prefer the updated snippets for new projects
  • RxJS bridge note: Added guidance for projects that still use RxJS streams, explaining how to use toSignal() at component boundaries

How did you test your changes?

Documentation review only. The code snippets provided are syntactically correct Angular 20+ code following official Angular patterns and best practices.

Types of changes

  • Change to the documentation

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • My changes require a documentation update.

https://claude.ai/code/session_01KG37ikpGHrkUUgcGKUotnW

marcin-kordas-hoc and others added 17 commits April 9, 2026 17:51
Add idiomatic code examples to React, Angular, Vue, and Svelte
integration pages showing HyperFormula initialization and reading
calculated values. Each guide uses framework-specific patterns
(React hooks, Angular service, Vue ref/markRaw, Svelte reactivity).

Closes HF-122.
Per feedback, snippets now focus on framework-specific integration
patterns (useRef/useEffect, @Injectable, markRaw/ref, Svelte reactivity)
with placeholder comments for data and configuration rather than
concrete values. The Demo section link is reworded from "Explore the
full working example" to "For a more advanced example" to signal that
the Stackblitz demo is a richer, separate project.

Part of HF-122.
Expand React, Angular, Vue and Svelte integration guides to cover
framework-specific concerns that the previous skeleton snippets omitted:

- Convert all snippets to TypeScript with HyperFormula/CellValue imports
- Add licenseKey: 'gpl-v3' to every buildFromArray call
- Inline `npm install hyperformula` install command
- React: runnable JSX with controlled inputs, try/catch around setCellContents,
  React.StrictMode note, Next.js App Router SSR section with 'use client' and
  dynamic import
- Angular: modern standalone component + inject() + DestroyRef + Signals +
  OnPush, RxJS BehaviorSubject variant with AsyncPipe import note, NgZone
  runOutsideAngular section, provider-scope + DestroyRef rationale
- Vue: <script setup lang="ts">, expanded markRaw Proxy explanation and
  shallowRef trap, Nuxt SSR snippet, Pinia store with updateCell action,
  valuesUpdated event hook, inline v-for template
- Svelte: fixes memory leak by adding onDestroy(() => hf.destroy()), Svelte 5
  runes primary example plus Svelte 4 delta, SvelteKit SSR warning banner and
  dedicated onMount section with dynamic import, wired #each template with
  updateCell handler
Point readers from each integration guide to related topics they are
likely to need next: configuration options, basic operations (CRUD),
advanced usage (multi-sheet, named expressions), and custom functions.

Identical section in all four guides so the navigation experience is
consistent when switching between frameworks.
The Stackblitz demo links used \${...} JavaScript template literal syntax,
which is not interpolated by VuePress. VuePress 1 processes markdown as
Vue templates, so the correct syntax for accessing the injected
\$page.buildDateURIEncoded variable is Vue's {{ ... }} interpolation.

config.js line 79 documents the intended syntax explicitly:
  // inject current HF buildDate URI encoded as {{ \$page.buildDateURIEncoded }} variable

Before this fix, the cache-buster query string rendered as a literal
?v=\${\$page.buildDateURIEncoded} in the URL, breaking the cache-busting
behaviour on every Stackblitz demo link.

Note: the same issue exists in docs/guide/custom-functions.md:361 from
an earlier change; that is left for a separate fix.
…ntent)

tsc smoke check found that updateCell(value: unknown) does not satisfy
setCellContents which expects RawCellContent. Replace unknown with the
correct type and add missing RawCellContent imports in Angular, Vue and
Svelte guides.
Add framework-agnostic instruction file for AI coding assistants
(Claude Code, GitHub Copilot, Cursor, Gemini CLI). Covers the core
3-operation API surface, framework integration patterns with critical
rules (markRaw, onDestroy, StrictMode, DestroyRef, SSR guards),
key types, common mistakes to prevent, and project structure pointers.
Angular: switch primary pattern to BehaviorSubject/Observable (module-based),
matching the angular-demo on Stackblitz. Signal-based variant moved to a
'Signals variant (Angular 17+)' note. Cleanup section expanded with both
ngOnDestroy and DestroyRef options.

Svelte: switch primary pattern to Svelte 4 style (on:click, plain let),
matching the svelte-demo on Stackblitz. Svelte 5 runes variant moved to
a '### Svelte 5 (runes)' subsection. SSR section updated to use Svelte 4
as primary.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
React: fix Next.js SSR pattern — 'use client' belongs in the component
file, not on page.tsx; server page uses dynamic(..., { ssr: false })

Angular: add CommonModule/standalone imports for *ngFor + async pipe;
add @for template for signals variant; add inject() context note

Vue: replace shallowRef with ref in Nuxt SSR snippet (shallowRef vs
markRaw contradiction); add hf.off() teardown to valuesUpdated example;
remove hf from Pinia store return value (devtools serialisation risk)

Svelte: fix CellValue type for result variable; fix SSR snippet to use
onMount return for cleanup instead of separate onDestroy

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Vue: rewrite primary snippet to use class wrapper pattern matching
the vue-3-demo on Stackblitz. markRaw moved to Notes as alternative.

Angular: remove unnecessary `as CellValue[][]` casts (getSheetValues
already returns this type).

React: remove try/catch from handleCellEdit for consistency — no demo
uses error handling around setCellContents.

custom-functions.md: fix VuePress template syntax (${}→{{}}) so the
Stackblitz link renders the build date correctly.

AGENTS.md: update framework table to match actual guide primary
patterns (Angular=BehaviorSubject, Vue=class wrapper, Svelte=Svelte 4).
…polation

{{ $page.buildDateURIEncoded }} inside markdown link syntax [text](url{{ }})
breaks markdown-it parsing — links render as plain text instead of clickable
links. Switch to <a :href="..."> with Vue v-bind which VuePress handles
correctly since page data is available in template scope.
Per Kuba's review feedback: snippets must match what's in the Stackblitz
demos so we can guarantee they work correctly. Removed all patterns that
have never been tested with HyperFormula:

Angular: removed Signals variant (signal, inject, DestroyRef, OnPush,
@for), NgZone.runOutsideAngular section.

Svelte: removed Svelte 5 runes ($state) section.

Vue: removed markRaw alternative, Nuxt SSR with dynamic import,
valuesUpdated event listener, Pinia store sections.

These patterns can be re-added once validated by a framework consultant
or included in updated demos.
All four Stackblitz demos use the same interaction model: "Run calculations"
and "Reset" buttons with read-only table output. Aligned guides to match:

React: replaced editable <input onChange> with button-driven calculate/reset.
The onChange-per-keystroke pattern was not from the demo and caused issues
with partial formula input.

Angular: replaced standalone component with NgModule pattern (matching demo).
Replaced updateCell with calculate/reset methods matching EmployeesService.
Added buttons to template.

Vue: replaced dead handleUpdate/updateCell with getCalculatedValues/
getRawFormulas matching EmployeesDataProvider. Added Run/Reset buttons.
AGENTS.md: Vue SSR guard updated from "onMounted + dynamic import"
to "<ClientOnly> (Nuxt)" matching the actual guide content.

Svelte: renamed "Calculate" to "Run calculations" and added "Reset"
button for consistency with React/Angular/Vue guides. Reset is pure
UI (result = null), no HF API involved.
Rewrites the guide to follow current Angular idioms: standalone
components (default since v19), signals instead of BehaviorSubject +
async pipe, @if / @for control flow (replaces deprecated *ngIf / *ngFor
from v20), inject() over constructor DI, DestroyRef.onDestroy() over
ngOnDestroy, and explicit ChangeDetectionStrategy.OnPush. Drops the
AppModule / CommonModule references that no longer apply to new
projects.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026

Performance comparison of head (33703c4) vs base (d6a316c)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 499.12 | 496.76 | -0.47%
                                      Sheet B | 159.47 | 160.53 | +0.66%
                                      Sheet T |  142.7 | 141.31 | -0.97%
                                Column ranges | 472.42 | 471.66 | -0.16%
Sheet A:  change value, add/remove row/column |  15.78 |  15.85 | +0.44%
 Sheet B: change value, add/remove row/column | 135.16 | 130.14 | -3.71%
                   Column ranges - add column | 149.86 | 147.32 | -1.69%
                Column ranges - without batch | 469.94 | 444.72 | -5.37%
                        Column ranges - batch | 119.67 |  116.1 | -2.98%

@marcin-kordas-hoc
Copy link
Copy Markdown
Collaborator

Picked nothing up from this PR into #1653 — the modernization (standalone components, signals, @if/@for, inject(DestroyRef), OnPush) breaks parity with the Stackblitz Angular demo, which still uses NgModule + RxJS BehaviorSubject + injectable service. Same rationale as #1657: snippet-vs-demo alignment is the foundation per 2026-04-10, and the modernization belongs in the consultant v2 pass.

Closing-suggestion: park until the Angular specialist task lands. I'll let you close at your discretion.

Base automatically changed from feature/hf-122-framework-integration-guides to develop May 7, 2026 12:17
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.18%. Comparing base (1852159) to head (33703c4).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1658      +/-   ##
===========================================
+ Coverage    96.77%   97.18%   +0.41%     
===========================================
  Files          174      174              
  Lines        15086    15086              
  Branches      3223     3223              
===========================================
+ Hits         14599    14662      +63     
+ Misses         487      424      -63     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants