Block FetchContent in CMake style checks#9124
Merged
alexreinking merged 3 commits intomainfrom May 7, 2026
Merged
Conversation
alexreinking
added
the
skip_buildbots
alexreinking
commented
May 7, 2026
Comment on lines
-130
to
+131
| name: check uv.lock is up to date | ||
| entry: uv lock --check | ||
| name: ensure uv.lock is up to date | ||
| entry: uv lock |
Member
Author
There was a problem hiding this comment.
Sorry for the drive-by, but I noticed I had to manually run uv lock on a different branch after this caught my mistake and I thought that was annoying. This does the right thing (fails but updates).
abadams
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #9116, I had to comment that FetchContent is not allowed and then do the dependency management work myself. I thought it would be good to document why we don't allow it and to extend the prohibited commands checker to notice when FetchContent is being introduced. Hopefully AI agents will pick up on this.
Checklist