chore: sweep prose and test conventions#85
Merged
Conversation
Partial pass over the sweep identified by two reviewers against
CLAUDE.md's naming rule ("name tests by the scenario they cover,
prefixed by the function name"). Touches only name changes where the
current wording described internal operations (appends/routes/returns
none/sets field) instead of observable outcomes; every rename has a
sibling test or adjacent scenario-phrased neighbour to anchor the
style.
Safety-net commit: this branch will be rebased onto main after PR #84
lands and the remaining comment / test-ordering priorities are
addressed in follow-up commits.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tightens prose and test organization against the repo conventions before the drift gets harder to review. The branch keeps behavior unchanged and focuses on comments, docs, ordering, and test names.
extra_ca_certsuser-guide behavior while keeping the trust-setting caveats visible./compactuser-facing docs around resume behavior, tracker reset, and queued prompts without describing raw JSONL mechanics.Design decisions
/compactdesign doc is long, but the feature is large enough to justify an internal design record. The user guide was the right place to trim implementation detail.Changes
docs/guide/configuration.mdextra_ca_certsand auth prose while preserving path-resolution and project-config rejection details.docs/guide/slash-commands.md/compactdocs around visible resume and tracker behavior.docs/design/slash/compact.mdCLAUDE.mdagent/event.rs,session/*,slash/*,tui/*,client/anthropic/*client/anthropic.rs,config/oauth.rs,tui/components/chat.rs,tui/components/input.rs,tui/modal/kv_overview.rsclient/anthropic.rs,config/oauth.rs,session/*,tui/components/*,tui/theme/loader.rsTest plan
cargo fmt --all --checkcargo buildcargo clippy --all-targets -- -D warnings: zero warningscargo test: 2025 tests passcargo llvm-cov --ignore-filename-regex 'main\.rs': 98.63% line coveragepnpm lint: 0 errorspnpm spellcheck: 0 issues