Skip to content

ci: Fix Windows build and support publishing to an existing release#6621

Open
incrypto32 wants to merge 2 commits into
masterfrom
incrypto32/v0.44.0-windows-build-fix
Open

ci: Fix Windows build and support publishing to an existing release#6621
incrypto32 wants to merge 2 commits into
masterfrom
incrypto32/v0.44.0-windows-build-fix

Conversation

@incrypto32

Copy link
Copy Markdown
Member

Two changes:

  • Bump anstream to 0.6.21. The 0.6.14 version that clap_builder pins fails to compile on Windows because of a trait conflict with the blanket impl added in anstyle-wincon 3.0.11 (E0119).
  • Add a release_tag workflow_dispatch input. When set, the release, publish-npm and publish-npm-wrapper jobs target that tag instead of github.ref_name, so binaries can be attached to an existing release and published as that version. Tag-ref dispatch behaves as before when the input is empty.

anstream 0.6.14 declares `impl WinconStream for &'_ mut Buffer` on
Windows, which now conflicts with the blanket
`impl<T: WinconStream> WinconStream for &mut T` added in
anstyle-wincon 3.0.11. The collision breaks Windows builds with E0119.

Bumping to the semver-compatible 0.6.21 drops the explicit impl and
resolves the conflict.
Adds a release_tag workflow_dispatch input. When set, the release,
publish-npm and publish-npm-wrapper jobs target the given tag instead
of github.ref_name, so a rebuilt artifact set can be attached to an
existing GitHub release and published to npm without cutting a new tag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants