perf: use _DummyListBuffer in test_reads.py to avoid GIL contention#16860
Open
zhixiangli wants to merge 2 commits intogoogleapis:mainfrom
Open
perf: use _DummyListBuffer in test_reads.py to avoid GIL contention#16860zhixiangli wants to merge 2 commits intogoogleapis:mainfrom
zhixiangli wants to merge 2 commits intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a _DummyListBuffer class to replace io.BytesIO in performance tests, which helps avoid GIL contention during profiling. Feedback includes a suggestion to make the write method compliant with standard Python io interfaces by returning the number of bytes written and a recommendation to optimize memory usage by removing chunk storage if the data content is not being verified.
Also fixed a pre-existing lint error (unused import io.BytesIO).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
io.BytesIOwith a custom_DummyListBufferintest_reads.py.During profiling,
io.BytesIO.write()holds the GIL while copying data. This introduces significant noise and bottlenecks in performance tests with high concurrency or large data transfers.This change avoids GIL contention and reduces noise when profiling the code (specifically noted by the user as causing noise when profiling the format code).