feat(Spanner): Add the built in metrics feature#9055
feat(Spanner): Add the built in metrics feature#9055Hectorhammett wants to merge 14 commits intomainfrom
Conversation
e2592f7 to
122f5fa
Compare
There was a problem hiding this comment.
"global" location is only a fallback , if customer application is not deployed on GCP. We need to detect Client location , if not available then fall back to GCP
There was a problem hiding this comment.
instance_id can not be blank as it is a monitored resource. If for some reason (should not be happening) the instance_id is not available use a default value like 'unknown' , else customer would see error
There was a problem hiding this comment.
So in reality this should never be empty, but I have this empty string as a fallback.
Is it preferable to instead not record any data in the case that we are missing this piece of information?
There was a problem hiding this comment.
I would recommend recording the data with "unknown" value, If we see some customers data with instance_id as "unknown" then we would know there is an issue. If we simply ignore the data then the logs will only be available with customers, and we will never get to know about the issue.
Eg: we were able to catch a edge case when we saw metrics data with "unknown" value in Java.
But this is not a hard requirement, will leave it upto you. If you feel this shall never happen, then you may simply ignore it.
There was a problem hiding this comment.
We should not be hardcoding the status to "OK" . We should wait for RPC completion and record the actual status. This is what has been done for other languages
d18bcfe to
14c50ad
Compare
Adds the Client built in metrics for Spanner.
b/406082122