Skip to content

test(spanner): replace fixed hashCode value assertions with contract-compliance tests in OptionsTest #12901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anishesg wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −4
Open

test(spanner): replace fixed hashCode value assertions with contract-compliance tests in OptionsTest #12901

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0965e96
test(spanner): replace fixed hashCode value assertions with contract-…
anishesg Apr 23, 2026
c957a44
test: remove tautological hashCode assertions and use idiomatic isEqu…
anishesg Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions java-spanner/google-cloud-spanner/src/test/java/com/google/cloud/spanner/OptionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,10 @@ public void allOptionsAbsent() {
assertThat(options.equals(null)).isFalse();
assertThat(options.equals(this)).isFalse();
assertNull(options.isolationLevel());
assertThat(options.hashCode()).isEqualTo(31);
// Verify hashCode contract: equal objects must have equal hashCodes.
Options options2 = Options.fromReadOptions();
assertThat(options).isEqualTo(options2);
assertThat(options.hashCode()).isEqualTo(options2.hashCode());
}

@Test
Expand All @@ -175,7 +178,12 @@ public void listOptionsTest() {
assertThat(options.pageSize()).isEqualTo(pageSize);
assertThat(options.pageToken()).isEqualTo(pageToken);
assertThat(options.filter()).isEqualTo(filter);
assertThat(options.hashCode()).isEqualTo(108027089);
// Verify hashCode contract: equal objects must have equal hashCodes.
Options options2 =
Options.fromListOptions(
Options.pageSize(pageSize), Options.pageToken(pageToken), Options.filter(filter));
assertThat(options).isEqualTo(options2);
assertThat(options.hashCode()).isEqualTo(options2.hashCode());
}

@Test
Expand Down Expand Up @@ -696,7 +704,10 @@ public void updateOptionsTest() {
assertEquals("tag: " + tag + " ", options.toString());
assertTrue(options.hasTag());
assertThat(options.tag()).isEqualTo(tag);
assertThat(options.hashCode()).isEqualTo(-2118248262);
// Verify hashCode contract: equal objects must have equal hashCodes.
Options options2 = Options.fromUpdateOptions(Options.tag(tag));
assertThat(options).isEqualTo(options2);
assertThat(options.hashCode()).isEqualTo(options2.hashCode());
}

@Test
Expand Down Expand Up @@ -728,7 +739,10 @@ public void transactionOptionsTest() {
assertEquals("tag: " + tag + " ", options.toString());
assertTrue(options.hasTag());
assertThat(options.tag()).isEqualTo(tag);
assertThat(options.hashCode()).isEqualTo(-2118248262);
// Verify hashCode contract: equal objects must have equal hashCodes.
Options options2 = Options.fromTransactionOptions(Options.tag(tag));
assertThat(options).isEqualTo(options2);
assertThat(options.hashCode()).isEqualTo(options2.hashCode());
}

@Test
Expand Down
Loading