Refactor ChainingConstructorIgnoresParameter to not store mutable state in BugChecker fields.#5786
Merged
copybara-service[bot] merged 1 commit intomasterfrom May 8, 2026
Merged
Conversation
…tate in `BugChecker` fields. Checkers shouldn't do that; I just didn't know better at the time. Future work in this vein: `FloggerRequiredModifiers`. This CL also fixes a [bug](http://sponge2/682f43a9-c73c-4a4f-9924-d8f09888ef06) that caused a `@SuppressWarnings` annotation on a callee constructor to suppress warnings in its caller. PiperOrigin-RevId: 912658003
copybara-service
Bot
force-pushed
the
test_912536575
branch
from
15921d3 to
6f96cef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
ChainingConstructorIgnoresParameterto not store mutable state inBugCheckerfields.Checkers shouldn't do that; I just didn't know better at the time.
Future work in this vein:
FloggerRequiredModifiers.This CL also fixes a bug that caused a
@SuppressWarningsannotation on a callee constructor to suppress warnings in its caller.