Skip to content

util/maven: do not add dependency management when version is empty#357

Merged
cuixq merged 1 commit into
google:mainfrom
cuixq:maven
Jun 11, 2026
Merged

util/maven: do not add dependency management when version is empty#357
cuixq merged 1 commit into
google:mainfrom
cuixq:maven

Conversation

@cuixq

@cuixq cuixq commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Maven POMs may contain <dependencyManagement> entries without a version field.

Previously, ProcessDependencies stored these versionless entries, preventing dependency management with the actual version constraint to be stored.

This PR updated addDepManagement in util/maven/dependency.go to explicitly require dep.Version != "" before adding an entry to the map.

@cuixq cuixq requested a review from slugclub June 11, 2026 04:34
@cuixq cuixq merged commit 4b37433 into google:main Jun 11, 2026
7 checks passed
@cuixq cuixq deleted the maven branch June 11, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants