fix(semver): restrict PEP 440 local version comparison to minimum length#352
Open
mramansayyad wants to merge 1 commit into
Open
fix(semver): restrict PEP 440 local version comparison to minimum length#352mramansayyad wants to merge 1 commit into
mramansayyad wants to merge 1 commit into
Conversation
…op to minimum length
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor logic issue in the PEP 440 local version comparison function where the loop counter compared up to the length of the first version string (pn) rather than the minimum of both version strings (n). This could lead to calling pep440LocalElem on an empty string and unnecessary iterations. Using n avoids this and compares only up to the shared components length.