utils: resolve vsock deadlock and remove IsConnected_Unguarded workaround#2686
Draft
sferrogoo wants to merge 1 commit into
Draft
utils: resolve vsock deadlock and remove IsConnected_Unguarded workaround#2686sferrogoo wants to merge 1 commit into
sferrogoo wants to merge 1 commit into
Conversation
…ound This change introduces a state_mutex_ in VsockConnection to safely synchronize access to the underlying file descriptor (fd_). The previous implementation used read_mutex_ and write_mutex_ to protect IsConnected() and Disconnect(), which created a circular lock dependency when these methods were called from within a Read() or Write() operation. By using a dedicated state_mutex_ to protect the FD state, we can now safely check connectivity and perform I/O without risk of deadlock. Bug: b/345285391 Test: verified with high-frequency stress test
sferrogoo
force-pushed
the
vsock_deadlock_fix
branch
from
4b01120 to
8a08243
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a state_mutex_ in VsockConnection to safely synchronize access to the underlying file descriptor (fd_).
The previous implementation used read_mutex_ and write_mutex_ to protect IsConnected() and Disconnect(), which created a circular lock dependency when these methods were called from within a Read() or Write() operation.
By using a dedicated state_mutex_ to protect the FD state, we can now safely check connectivity and perform I/O without risk of deadlock.
Bug: b/345285391
Test: verified with high-frequency stress test