fix: use correct 'content' key in sandbox code executor input files#5505
Open
weiguangli-io wants to merge 2 commits intogoogle:mainfrom
Open
fix: use correct 'content' key in sandbox code executor input files#5505weiguangli-io wants to merge 2 commits intogoogle:mainfrom
weiguangli-io wants to merge 2 commits intogoogle:mainfrom
Conversation
Fixes google#5500. The input file payload used 'contents' (plural) but the Vertex AI SDK reads 'content' (singular), causing uploaded files to arrive as zero bytes in the sandbox with no error raised.
Collaborator
|
Response from ADK Triaging Agent Hello @weiguangli-io, thank you for creating this PR! This PR is a bug fix, could you please include a In addition, could you please provide logs or screenshot after the fix is applied? This information will help reviewers to review your PR more efficiently. Thanks! |
adk-bot
added
the
core
Collaborator
|
Hi @weiguangli-io , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
rohityan
added
the
needs review
Collaborator
|
Hi @sasha-gitg , can you please review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5500
Root Cause
AgentEngineSandboxCodeExecutorbuilds the input file payload with key'contents'(plural), but the Vertex AI SDK (vertexai/_genai/sandboxes.py) reads'content'(singular). This causesfile.get("content", b"")to always return the default empty bytes, so uploaded input files silently arrive as zero bytes in the sandbox.Fix
One-character change:
'contents'→'content'at line 177.