fix: support OpenTelemetry 1.39+ by relaxing version constraints#4913
fix: support OpenTelemetry 1.39+ by relaxing version constraints#4913brucearctor wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Hi @brucearctor, Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
|
Hi @Jacksunwei , can you please review this. |
|
hi, what's the latest here? |
|
google-adk 1.15+ transitively pulls opentelemetry-exporter-gcp-logging (via google-cloud-aiplatform[agent-engines]), and THAT package also caps OTel <1.39.0. Is there any work on that side @rohityan |
5aea40f to
c8d0aae
Compare
|
@partha-lgtm It looks like that concern has actually already been addressed upstream. The opentelemetry-exporter-gcp-logging package was updated in GoogleCloudPlatform/opentelemetry-operations-python#461 — versions 1.10.0a0+ now require opentelemetry-sdk >= 1.39.0 (flipping the old < 1.39.0 cap). You can see the current constraint in setup.cfg. So once this PR's OTel relaxation to < 2.0.0 lands, pip will resolve to opentelemetry-exporter-gcp-logging >= 1.10.0a0 alongside OTel 1.39+. No additional changes needed on the transitive side, unless I am missing something? |
592b812 to
8bcae39
Compare
Link to Issue or Description of Change
1. Link to an existing issue:
Description
The
<1.39.0upper bound onopentelemetry-apiandopentelemetry-sdkwas added due toagent_enginesexporter constraints ingoogle-cloud-aiplatform. The upstream package (latest v1.141.0) now specifiesopentelemetry-sdk<2for both theagent-enginesandreasoningengineextras, so this constraint is no longer needed.Changes:
opentelemetry-api>=1.36.0, <1.39.0→opentelemetry-api>=1.36.0, <2.0.0opentelemetry-sdk>=1.36.0, <1.39.0→opentelemetry-sdk>=1.36.0, <2.0.0Testing Plan
Unit Tests:
Manual End-to-End (E2E) Tests:
N/A — no code changes, only dependency metadata.
Checklist
Additional context
Verified on PyPI that
google-cloud-aiplatform==1.141.0specifiesopentelemetry-sdk<2foragent-enginesextra, confirming the upstream constraint has been relaxed.