feat(gooddata-sdk): [AUTO] Add conversation responses list and feedback endpoints in gen-ai#1551
Closed
yenkins-admin wants to merge 2 commits intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] Add conversation responses list and feedback endpoints in gen-ai#1551yenkins-admin wants to merge 2 commits intomasterfrom
yenkins-admin wants to merge 2 commits intomasterfrom
Conversation
…ck endpoints in gen-ai
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1551 +/- ##
==========================================
- Coverage 78.66% 78.61% -0.05%
==========================================
Files 230 231 +1
Lines 15405 15463 +58
==========================================
+ Hits 12118 12157 +39
- Misses 3287 3306 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The implement agent writes its message log to transcript-implement-C014.jsonl. This file was accidentally committed by 'git add -A' in the deliver step of sdk-py-openapi-sync.yml (gdc-nas). The workflow has been patched to write transcripts outside the sdk/ checkout so future auto-PRs won't contain them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added SDK support for the two new gen-ai conversation response endpoints: GET conversation responses and PATCH response feedback. Created model classes (ConversationFeedback, ConversationTurnResponse, ConversationResponseList) in compute/model/ai_chat.py, added _do_get_request and _do_patch_request to GoodDataApiClient, added get_conversation_responses and set_conversation_response_feedback service methods to ComputeService, exported new classes from init.py, and added 12 unit tests covering all model serialization paths.
Impact: new_feature | Services:
gen-aiTickets: GDAI-1448
Files changed
packages/gooddata-sdk/src/gooddata_sdk/compute/model/ai_chat.pypackages/gooddata-sdk/src/gooddata_sdk/client.pypackages/gooddata-sdk/src/gooddata_sdk/compute/service.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/compute/test_ai_chat_models.pyAgent decisions
Decisions (4)
Model class location — compute/model/ai_chat.py — standalone attrs classes without Base
HTTP client methods — Added _do_get_request and _do_patch_request to GoodDataApiClient; also updated do_request to handle PATCH
ResponseFeedbackRequest body structure — Wrapped FeedbackDto in { 'feedback': {...} } envelope
ConversationTurnResponse unused import fix — Ruff removed unused ConversationTurnResponse import from service.py automatically
Assumptions to verify (4)
Risks (2)
Layers touched (4)
packages/gooddata-sdk/src/gooddata_sdk/compute/model/ai_chat.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/src/gooddata_sdk/client.pypackages/gooddata-sdk/src/gooddata_sdk/compute/service.pypackages/gooddata-sdk/tests/compute/test_ai_chat_models.pySource commits (gdc-nas)
e58ab04Merge pull request #21392 from gooddata/js/GDAI-1448OpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow