Skip to content

feat(gooddata-sdk): [AUTO] Add HYPERLOGLOG to attribute value type enums#1550

Closed
yenkins-admin wants to merge 2 commits intomasterfrom
auto/openapi-sync-C001-20260419-r33866
Closed

feat(gooddata-sdk): [AUTO] Add HYPERLOGLOG to attribute value type enums#1550
yenkins-admin wants to merge 2 commits intomasterfrom
auto/openapi-sync-C001-20260419-r33866

Conversation

@yenkins-admin
Copy link
Copy Markdown
Contributor

Summary

Added HYPERLOGLOG (and IMAGE, which was already in the API spec but missing from the enum) to the GoodDataLabelType enum in packages/gooddata-dbt/src/gooddata_dbt/dbt/base.py. The gooddata-sdk package uses plain str | None for value_type with no enum constraint, so no changes were needed there. The auto-generated gooddata-api-client already has HYPERLOGLOG in its allowed_values dicts.

Impact: enum_addition | Services: gooddata-afm-client, gooddata-metadata-client

Files changed

  • packages/gooddata-dbt/src/gooddata_dbt/dbt/base.py

Agent decisions

Decisions (2)

IMAGE also added alongside HYPERLOGLOG — Added both IMAGE and HYPERLOGLOG to GoodDataLabelType

  • Alternatives: Add only HYPERLOGLOG as stated in the diff
  • Why: IMAGE was already in the API spec before this change but was absent from GoodDataLabelType, making the enum out of sync. Adding both aligns the dbt enum with the full API-supported set.

gooddata-sdk declarative model left unchanged — Left CatalogDeclarativeLabel.value_type as str | None = None

  • Alternatives: Add enum validation via value_in_allowed validator
  • Why: The field accepts any string with no existing validator; adding one would be a breaking change. The auto-generated API client validates on its side.
Assumptions to verify (2)
  • The gooddata-api-client is already regenerated with HYPERLOGLOG in allowed_values (confirmed by reading declarative_label.py which shows HYPERLOGLOG: 'HYPERLOGLOG').
  • IMAGE was absent from GoodDataLabelType before this change (oversight or intentional dbt exclusion). Adding it now is consistent with the full API enum.
Layers touched (1)
  • entity_model — GoodDataLabelType enum extended with IMAGE and HYPERLOGLOG values to match the full API enum
    • packages/gooddata-dbt/src/gooddata_dbt/dbt/base.py

Source commits (gdc-nas)

  • 6faf4e2 Merge pull request #21484 from pcerny/pce/cq-2118_hll_sr
OpenAPI diff
--- a/gooddata-afm-client.json
+++ b/gooddata-afm-client.json
@@ -841,7 +841,8 @@
                   "GEO_LATITUDE",
                   "GEO_AREA",
                   "GEO_ICON",
-                  "IMAGE"
+                  "IMAGE",
+                  "HYPERLOGLOG"
                 ],
                 "type": "string"
@@ -3208,7 +3264,8 @@
               "GEO_LATITUDE",
               "GEO_AREA",
               "GEO_ICON",
-              "IMAGE"
+              "IMAGE",
+              "HYPERLOGLOG"
--- a/gooddata-metadata-client.json
+++ b/gooddata-metadata-client.json
@@ -5575,7 +5575,8 @@
               "GEO_LATITUDE",
               "GEO_AREA",
               "GEO_ICON",
-              "IMAGE"
+              "IMAGE",
+              "HYPERLOGLOG"
             ],
             "example": "HYPERLINK",
             "type": "string"
@@ -8277,7 +8384,8 @@
               "GEO_LATITUDE",
               "GEO_AREA",
               "GEO_ICON",
-              "IMAGE"
+              "IMAGE",
+              "HYPERLOGLOG"
@@ -20241,7 +20350,8 @@
                   "GEO_LATITUDE",
                   "GEO_AREA",
                   "GEO_ICON",
-                  "IMAGE"
+                  "IMAGE",
+                  "HYPERLOGLOG"

Workflow run


Generated by SDK OpenAPI Sync workflow

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.66%. Comparing base (37d0593) to head (d8e1f5e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1550   +/-   ##
=======================================
  Coverage   78.66%   78.66%           
=======================================
  Files         230      230           
  Lines       15405    15407    +2     
=======================================
+ Hits        12118    12120    +2     
  Misses       3287     3287           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The implement agent writes its message log to transcript-implement-C001.jsonl.
This file was accidentally committed by 'git add -A' in the deliver step of
sdk-py-openapi-sync.yml (gdc-nas).  The workflow has been patched to write
transcripts outside the sdk/ checkout so future auto-PRs won't contain them.
@tychtjan tychtjan closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants