feat(gooddata-sdk): [AUTO] Add HYPERLOGLOG to attribute value type enums#1550
Closed
yenkins-admin wants to merge 2 commits intomasterfrom
Closed
feat(gooddata-sdk): [AUTO] Add HYPERLOGLOG to attribute value type enums#1550yenkins-admin wants to merge 2 commits intomasterfrom
yenkins-admin wants to merge 2 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1550 +/- ##
=======================================
Coverage 78.66% 78.66%
=======================================
Files 230 230
Lines 15405 15407 +2
=======================================
+ Hits 12118 12120 +2
Misses 3287 3287 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The implement agent writes its message log to transcript-implement-C001.jsonl. This file was accidentally committed by 'git add -A' in the deliver step of sdk-py-openapi-sync.yml (gdc-nas). The workflow has been patched to write transcripts outside the sdk/ checkout so future auto-PRs won't contain them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added HYPERLOGLOG (and IMAGE, which was already in the API spec but missing from the enum) to the GoodDataLabelType enum in packages/gooddata-dbt/src/gooddata_dbt/dbt/base.py. The gooddata-sdk package uses plain str | None for value_type with no enum constraint, so no changes were needed there. The auto-generated gooddata-api-client already has HYPERLOGLOG in its allowed_values dicts.
Impact: enum_addition | Services:
gooddata-afm-client,gooddata-metadata-clientFiles changed
packages/gooddata-dbt/src/gooddata_dbt/dbt/base.pyAgent decisions
Decisions (2)
IMAGE also added alongside HYPERLOGLOG — Added both IMAGE and HYPERLOGLOG to GoodDataLabelType
gooddata-sdk declarative model left unchanged — Left CatalogDeclarativeLabel.value_type as str | None = None
Assumptions to verify (2)
Layers touched (1)
packages/gooddata-dbt/src/gooddata_dbt/dbt/base.pySource commits (gdc-nas)
6faf4e2Merge pull request #21484 from pcerny/pce/cq-2118_hll_srOpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow