[codex] Support SSH commit signing via external signers#2917
Draft
xiaotianxt wants to merge 2 commits intogitui-org:masterfrom
Draft
[codex] Support SSH commit signing via external signers#2917xiaotianxt wants to merge 2 commits intogitui-org:masterfrom
xiaotianxt wants to merge 2 commits intogitui-org:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2188.
What changed
gpg.ssh.program, defaulting tossh-keygenuser.signingKeyas a private-key path, public-key path, literal public key, orkey::...ssh-keydependency and movetempfileto runtime depsWhy
The existing SSH signing implementation only handled private keys stored on disk. That breaks real Git-supported setups such as ssh-agent-backed signing and external signers like 1Password's
op-ssh-sign, even though native Git handles those configurations correctly.Impact
user.signingKeyno longer fail during signer constructionssh-keyNotes
gpg.ssh.defaultKeyCommand; that should stay as a follow-up to keep the scope focusedsync::branch::merge_ff::test::test_merge_fastforwardduringcargo test --workspace; rerunning that test in isolation passedmake checkcannot complete on this machine becausecargo-nextest,tombi, andcargo-denyare not installed locallyValidation
cargo fmt --checkcargo clippy --workspace --all-featurescargo test -p asyncgitcargo checkcargo test --workspacessh-keygen -Y sign -U/Applications/1Password.app/Contents/MacOS/op-ssh-sign