Skip to content

Potential fixes for 2 code scanning alerts #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cinderellasecure wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Potential fixes for 2 code scanning alerts #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b3e0ea
Potential fix for code scanning alert no. 12: Workflow does not conta…
cinderellasecure Nov 4, 2025
cf00f43
Potential fix for code scanning alert no. 11: Workflow does not conta…
cinderellasecure Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ on: [push]
jobs:
build:
runs-on: ubuntu-latest
permissions:
contents: read

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/publish-beta.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
name: Publish Beta Package to npmjs
permissions:
contents: read
Comment on lines +2 to +3
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] In publish-beta.yml, permissions are set at the workflow level (lines 2-3), while in ci.yml, permissions are set at the job level (lines 8-9). For consistency and maintainability, consider using the same permission scope pattern across all workflows. Job-level permissions are generally preferred as they provide more granular control if multiple jobs are added later.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown

@jibrang jibrang Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we'll need write permissions as well since this step is to publish a package?

on:
push:
branches:
Expand Down
Loading