Add Zed integration by arrrrny · Pull Request #2780 · github/spec-kit

arrrrny · 2026-05-31T08:39:58Z

Summary

add a built-in zed integration that installs Spec Kit commands as Zed skills under .agents/skills
render Zed skill invocations correctly in init next-steps output and hook messages
add integration coverage for Zed plus registry/list assertions and docs updates

Testing

uv run --extra test python3 -m pytest tests/integrations/test_registry.py tests/integrations/test_integration_subcommand.py::TestIntegrationList::test_list_shows_available_integrations tests/integrations/test_integration_zed.py -q

Closes #2779

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds Zed editor as a new skills-based integration that installs Spec Kit commands as .agents/skills/speckit-<name>/SKILL.md files invokable via Zed's slash-command menu.

Changes:

New ZedIntegration class registered in the integrations registry
Hook invocation rendering and init-flow handling for zed skill mode
Documentation, registry, and integration-test updates including a new test_integration_zed.py

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/specify_cli/integrations/zed/init.py	New `ZedIntegration` (skills-based, `.agents/skills`, `AGENTS.md`)
src/specify_cli/integrations/init.py	Imports and registers `ZedIntegration`
src/specify_cli/extensions.py	Adds `zed_skill_mode` branch rendering `/skill-name` invocations
src/specify_cli/commands/init.py	Adds Zed to skill-mode flags, post-init step, and display command logic
docs/reference/integrations.md	Adds Zed row to integrations table
docs/index.md	Bumps integration count from 30 to 31 and lists Zed
tests/integrations/test_registry.py	Adds `zed` to expected-keys list
tests/integrations/test_integration_subcommand.py	Asserts `zed` appears in `list` output
tests/integrations/test_integration_zed.py	New tests for Zed integration and hook invocation rendering

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mnriem

Please address Copilot feedback

…am/main resolving conflicts

arrrrny · 2026-06-01T17:52:04Z

Side note, I have been using it last couple days and it works as expected

Copilot

Copilot's findings

Files reviewed: 9/9 changed files
Comments generated: 1

mnriem · 2026-06-02T22:20:54Z

Please address Copilot feedback and the test & lint errors

…ration

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

- Remove non-actionable --skills flag from ZedIntegration (Zed is always skills-based, like Agy) - Align zed_skill_mode predicate with ai_skills for consistency across init output and hook rendering - Consolidate claude/cursor/zed slash-skill return blocks in _render_hook_invocation to reduce duplication - Override test_options_include_skills_flag for Zed (no --skills flag)

Copilot

Copilot's findings

Files reviewed: 9/9 changed files
Comments generated: 1

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

- Make zed_skill_mode unconditional in hook rendering (Zed is always skills-based, no --skills option) - Add test_init_persists_ai_skills_for_zed that exercises the actual CLI init path and verifies HookExecutor renders /speckit-plan without manual init-options manipulation

Copilot

Copilot's findings

Files reviewed: 9/9 changed files
Comments generated: 2

mnriem

Please address Copilot feedback

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

arrrrny · 2026-06-09T18:38:24Z

Addressed the latest Copilot review comment (agy/trae invocation inconsistency) in 045afb9:

Moved agy_skill_mode and trae_skill_mode from the $speckit-{name} (Codex-specific) branch to the /speckit-{name} (standard slash format) branch in _display_cmd() in init.py
Now consistent with:
- HookExecutor._render_hook_invocation() (trae in ALWAYS_SLASH_AGENTS, agy in CONDITIONAL_SLASH_AGENTS)
- SkillsIntegration.build_command_invocation() (default: returns /speckit-<name>)

Also addressed the earlier F841 unused-variable comments (claude_skill_mode, cursor_skill_mode) in 5f3cdb4.

Resolved conflicts: - src/specify_cli/commands/init.py: function param formatting + removed git init / branch_numbering code from upstream/main (Zed-specific additions preserved) - src/specify_cli/extensions.py: cache write encoding (accepted upstream/main's utf-8 + OSError handling) - tests/integrations/test_integration_zed.py: removed --no-git flag (no longer accepted by the CLI)

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

- Add is_slash_skills_agent() helper to extensions.py to centralize the agent-to-invocation-format mapping, reducing drift risk between HookExecutor._render_hook_invocation() and init.py _display_cmd() - Use the shared helper in both locations; init.py now imports and delegates to is_slash_skills_agent() instead of maintaining its own per-agent boolean matrix - Fix test_hooks_render_skill_invocation to use ai_skills=False, proving Zed renders /speckit-<name> unconditionally - Add parameterized TestSlashSkillsSets covering all agents in ALWAYS_SLASH_AGENTS and CONDITIONAL_SLASH_AGENTS with ai_skills both true and false

arrrrny · 2026-06-09T18:51:54Z

Addressed all 4 new Copilot review comments in 3e750e8:

1-2. test_hooks_render_skill_invocation now uses ai_skills: False — proves Zed unconditionally renders /speckit-plan even when ai_skills is disabled.

3. Added parameterized TestSlashSkillsSets — 14 test cases covering every agent in ALWAYS_SLASH_AGENTS (devin, trae, zed) and CONDITIONAL_SLASH_AGENTS (agy, claude, copilot, cursor-agent), each with ai_skills both True and False, asserting the expected invocation format. This locks in the semantic contract of the shared constant sets.

4. Centralized invocation-style logic — extracted is_slash_skills_agent(selected_ai, ai_skills_enabled) as a module-level helper in extensions.py. Both HookExecutor._render_hook_invocation() and init.py's _display_cmd() now delegate to this single function instead of maintaining duplicate per-agent boolean matrices. Adding a new agent to ALWAYS_SLASH_AGENTS / CONDITIONAL_SLASH_AGENTS now automatically updates both hook rendering and init messaging.

Copilot

Copilot's findings

Files reviewed: 9/9 changed files
Comments generated: 3

mnriem · 2026-06-09T22:58:19Z

Please address Copilot feedback

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

- Make is_slash_skills_agent() accept str | None to match its call sites (init_options.get("ai") can return None) - Refactor TestSlashSkillsSets to use public execute_hook() API instead of private _render_hook_invocation() method

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

- Add from __future__ import annotations to extensions.py so PEP 604 unions (str | None) are safe regardless of Python version - Add clarifying _ai_skills_enabled local variable in init.py's _display_cmd() to make the semantic meaning explicit when passing it to is_slash_skills_agent()

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

+    registrar_config = {
+        "dir": ".agents/skills",
+        "format": "markdown",
+        "args": "$ARGUMENTS",
+        "extension": "/SKILL.md",
+    }


+        from ..extensions import is_slash_skills_agent as _is_slash_skills_agent
+
+        # `_is_skills_integration` means the integration is installed in
+        # skills mode, which is the semantic equivalent of `ai_skills_enabled`
+        # used by `is_slash_skills_agent()`.
+        _ai_skills_enabled = _is_skills_integration
+
        def _display_cmd(name: str) -> str:


- Extract ALWAYS_SLASH_AGENTS, CONDITIONAL_SLASH_AGENTS, and is_slash_skills_agent() from extensions.py into new _invocation_style.py module, eliminating the awkward init.py -> extensions.py import dependency for invocation-style decision logic - Both HookExecutor._render_hook_invocation() and init.py _display_cmd() now import from the shared module instead of one subsystem importing from the other - Revert /SKILL.md change: the leading slash is semantically significant (path component vs filename suffix)

…_flag get_integration() returns IntegrationBase | None, so i.options() is a type error without a None check.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

+    def test_options_include_skills_flag(self):
+        """Zed is always skills-based; no --skills option needed."""
+        i = get_integration(self.KEY)
+        assert i is not None
+        skills_opts = [o for o in i.options() if o.name == "--skills"]
+        assert len(skills_opts) == 0, (
+            "Zed is always skills-based and should not expose a --skills option"
+        )


…, no --skills flag) Zed is always skills-based and doesn't expose a --skills option. Override the inherited base test to assert --skills is absent.

arrrrny · 2026-06-10T06:11:05Z

Regarding the /SKILL.md leading slash in registrar_config["extension"] — this is intentional and is a project-wide convention used by all SkillsIntegration subclasses (Claude, Codex, Agy, etc.). The leading / is semantically significant: it tells the command rendering system that the extension is a path component (speckit-<name>/SKILL.md), not a filename suffix (speckit-<name>SKILL.md). Without it, skills would be written as e.g. speckit.agent-context.updateSKILL.md instead of speckit.agent-context.update/SKILL.md (confirmed by a test regression when the leading / was removed). The extension field is also never consumed by pathlib.Path or os.path.join in the current codebase — it is used as a suffix pattern, not a filesystem path.

This is not something that should be changed in just the Zed integration — it would require updating all SkillsIntegration subclasses and the base test assertion, which is out of scope for this PR.

Copilot

Copilot's findings

Files reviewed: 10/10 changed files
Comments generated: 0 new

mnriem · 2026-06-10T19:43:01Z

Please resolve conflicts

feat: add Zed integration

b122303

arrrrny requested a review from mnriem as a code owner May 31, 2026 08:39

Copilot AI review requested due to automatic review settings May 31, 2026 08:39

Copilot AI reviewed May 31, 2026

View reviewed changes

Comment thread src/specify_cli/integrations/zed/__init__.py Outdated

mnriem requested changes Jun 1, 2026

View reviewed changes

fix: address Copilot review - fix docstring punctuation, merge upstre…

1d20a63

…am/main resolving conflicts

mnriem requested a review from Copilot June 2, 2026 14:48

Copilot started reviewing on behalf of mnriem June 2, 2026 14:48 View session

Copilot AI reviewed Jun 2, 2026

View reviewed changes

Comment thread docs/index.md Outdated

arrrrny added 2 commits June 3, 2026 02:07

fix: update integrations stats grid to 31 for consistency

d6df1e8

Merge remote-tracking branch 'upstream/main' into feat/2779-zed-integ…

d2538e7

…ration

Copilot AI review requested due to automatic review settings June 2, 2026 23:10

Copilot AI reviewed Jun 2, 2026

View reviewed changes

arrrrny requested a review from mnriem June 2, 2026 23:22

mnriem requested a review from Copilot June 3, 2026 13:43

Copilot started reviewing on behalf of mnriem June 3, 2026 13:43 View session

Copilot AI reviewed Jun 3, 2026

View reviewed changes

Comment thread src/specify_cli/integrations/zed/__init__.py Outdated

Potential fix for pull request finding

e4f3b4c

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 3, 2026 14:28

Copilot AI reviewed Jun 3, 2026

View reviewed changes

Comment thread src/specify_cli/extensions.py Outdated

Comment thread tests/integrations/test_integration_zed.py Outdated

mnriem requested a review from Copilot June 3, 2026 19:43

Copilot started reviewing on behalf of mnriem June 3, 2026 19:43 View session

Copilot AI reviewed Jun 3, 2026

View reviewed changes

Comment thread docs/index.md Outdated

Comment thread docs/index.md Outdated

mnriem requested changes Jun 3, 2026

View reviewed changes

Potential fix for pull request finding

52b6d0b

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 4, 2026 03:52

Copilot AI review requested due to automatic review settings June 9, 2026 18:44

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread tests/integrations/test_integration_zed.py Outdated

Comment thread tests/integrations/test_integration_zed.py Outdated

Comment thread src/specify_cli/extensions.py Outdated

Comment thread src/specify_cli/commands/init.py

mnriem requested a review from Copilot June 9, 2026 21:30

Copilot started reviewing on behalf of mnriem June 9, 2026 21:31 View session

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread src/specify_cli/extensions.py Outdated

Comment thread src/specify_cli/extensions.py Outdated

Comment thread src/specify_cli/commands/init.py

Copilot AI review requested due to automatic review settings June 10, 2026 03:13