Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new built-in Lingma (通义灵码) integration to Spec Kit so specify init / specify integration install can scaffold Lingma’s skills-based file layout and context rules.
Changes:
- Introduces
LingmaIntegrationas aSkillsIntegrationusing.lingma/skills/speckit-<name>/SKILL.mdplus.lingma/rules/specify-rules.md. - Registers the new integration in the built-in integration registry and catalog.
- Adds a skills integration test suite entry for
lingma.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/integrations/lingma/__init__.py |
Implements the new Lingma integration (skills layout + context file + options). |
src/specify_cli/integrations/__init__.py |
Registers LingmaIntegration in the built-in integration registry. |
integrations/catalog.json |
Adds lingma to the built-in integration catalog metadata. |
docs/reference/integrations.md |
Documents Lingma in the supported integrations table. |
tests/integrations/test_integration_lingma.py |
Adds inherited skills integration tests for the new integration key/layout. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/5 changed files
- Comments generated: 1
| IntegrationOption( | ||
| "--skills", | ||
| is_flag=True, | ||
| default=True, | ||
| help="Install as agent skills (default for lingma since v0.5.1)", | ||
| ), |
There was a problem hiding this comment.
IntegrationOption.default values aren’t currently applied by _parse_integration_options() (it only returns explicitly provided tokens). Setting default=True here and describing it as the default can be misleading to callers that look at parsed options. Consider either (a) removing the default= / “default …” wording, or (b) updating _parse_integration_options() to populate defaults for all declared options when not provided.
mnriem
left a comment
mnriem
left a comment
There was a problem hiding this comment.
Please address Copilot feedback
Summary
Add built-in integration support for Lingma (通义灵码 by Alibaba) IDE.
Changes
New Integration: Lingma IDE
LingmaIntegration(src/specify_cli/integrations/lingma/__init__.py)SkillsIntegrationwith.lingma/skills/speckit-<name>/SKILL.mdlayoutrequires_cli: False), no CLI tool check required.lingma/rules/specify-rules.md_register()call insrc/specify_cli/integrations/__init__.pylingmaentry inintegrations/catalog.jsontests/integrations/test_integration_lingma.py(26 tests, all passing)