Skip to content

[test-improver] Improve tests for cmd/flags_difc #4465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 1 commit into from
Apr 24, 2026
+17 −13
Merged

[test-improver] Improve tests for cmd/flags_difc #4465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 17 additions & 13 deletions internal/cmd/flags_difc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package cmd

import (
"os"
"testing"

"github.com/github/gh-aw-mcpg/internal/config"
Expand Down Expand Up @@ -110,20 +109,10 @@ func TestGetDefaultDIFCMode(t *testing.T) {

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// Save and restore original env
originalEnv := os.Getenv("MCP_GATEWAY_GUARDS_MODE")
defer func() {
if originalEnv != "" {
os.Setenv("MCP_GATEWAY_GUARDS_MODE", originalEnv)
} else {
os.Unsetenv("MCP_GATEWAY_GUARDS_MODE")
}
}()

if tt.envValue != "" {
os.Setenv("MCP_GATEWAY_GUARDS_MODE", tt.envValue)
t.Setenv("MCP_GATEWAY_GUARDS_MODE", tt.envValue)
} else {
os.Unsetenv("MCP_GATEWAY_GUARDS_MODE")
t.Setenv("MCP_GATEWAY_GUARDS_MODE", "")
}

got := getDefaultDIFCMode()
Expand Down Expand Up @@ -179,11 +168,26 @@ func TestParseDIFCSinkServerIDs(t *testing.T) {
input: "safeoutputs,github,safeoutputs",
expect: []string{"safeoutputs", "github"},
},
{
name: "consecutive commas skip empty parts",
input: "safeoutputs,,github",
expect: []string{"safeoutputs", "github"},
},
{
name: "trailing comma skips empty part",
input: "safeoutputs,github,",
expect: []string{"safeoutputs", "github"},
},
{
name: "rejects embedded whitespace",
input: "safe outputs",
wantErr: true,
},
{
name: "rejects embedded tab",
input: "safe\toutputs",
wantErr: true,
},
}

for _, tt := range tests {
Expand Down
Loading