Skip to content

[GHSA-cq8v-f236-94qc] Rand is unsound with a custom logger using rand::rng() #7481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
advisory-database merged 1 commit into from
Apr 22, 2026
Merged

[GHSA-cq8v-f236-94qc] Rand is unsound with a custom logger using rand::rng() #7481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions advisories/github-reviewed/2026/04/GHSA-cq8v-f236-94qc/GHSA-cq8v-f236-94qc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"schema_version": "1.4.0",
"id": "GHSA-cq8v-f236-94qc",
"modified": "2026-04-14T01:03:36Z",
"modified": "2026-04-14T01:03:37Z",
"published": "2026-04-14T01:03:36Z",
"aliases": [],
"summary": "Rand is unsound with a custom logger using rand::rng()",
Expand All @@ -18,7 +18,7 @@
"type": "ECOSYSTEM",
"events": [
{
"introduced": "0.7.0"
"introduced": "0.9.0"
},
{
"fixed": "0.9.3"
Comment on lines +21 to 24
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The advisory mixes an ECOSYSTEM range that is fixed at 0.9.3 with an explicit vulnerable versions entry for 0.10.0. If 0.10.0 is intended to be vulnerable, it’s clearer (and typically easier for tooling) to represent it as an additional ranges[].events segment (e.g., an introduced: "0.10.0" event, optionally with a fixed if known) rather than (or in addition to) a standalone versions list.

Copilot uses AI. Check for mistakes.
Expand Down Expand Up @@ -48,6 +48,25 @@
"versions": [
"0.10.0"
]
Comment on lines 48 to 50
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The advisory mixes an ECOSYSTEM range that is fixed at 0.9.3 with an explicit vulnerable versions entry for 0.10.0. If 0.10.0 is intended to be vulnerable, it’s clearer (and typically easier for tooling) to represent it as an additional ranges[].events segment (e.g., an introduced: "0.10.0" event, optionally with a fixed if known) rather than (or in addition to) a standalone versions list.

Copilot uses AI. Check for mistakes.
},
{
"package": {
"ecosystem": "crates.io",
"name": "rand"
},
"ranges": [
{
"type": "ECOSYSTEM",
"events": [
{
"introduced": "0.7.0"
},
{
"fixed": "0.8.6"
}
]
}
]
Comment on lines +52 to +69
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR adds a second affected entry for the same package (rand). If the existing affected array already contains a rand entry (it appears to, given the other rand-line changes), consider consolidating into a single affected item with multiple ranges blocks (one per maintenance line: 0.7–0.8.6, 0.9–0.9.3, etc.). This reduces duplication and makes future edits (e.g., adding a 0.10.x fix) less error-prone.

Copilot uses AI. Check for mistakes.
}
],
"references": [
Expand Down
Loading