ref(sentry-panic): PanicInfo → PanicHookInfo

[mvanhorn]

Closes #862.

The workspace MSRV is 1.88 (Cargo.toml), so std::panic::PanicHookInfo (stabilized in 1.81) is always available. This removes the six #[allow(deprecated)] annotations that were silencing the PanicInfo deprecation warning and uses PanicHookInfo directly in sentry-panic.

Source compatibility

std keeps PanicInfo as a type alias for PanicHookInfo:

// library/std/src/panic.rs
pub type PanicInfo<'a> = PanicHookInfo<'a>;

So downstream extractor closures that still use &PanicInfo<'_> continue to match the new &PanicHookInfo<'_> signatures on add_extractor, event_from_panic_info, and message_from_panic_info.

Scope

Only sentry-panic/src/lib.rs is touched. No other crates reference PanicInfo.

Verified with cargo build --all, cargo clippy -p sentry-panic, cargo fmt -p sentry-panic --check, and cargo test -p sentry-panic.

[sdk-maintainer-bot]

This PR has been automatically closed. The referenced issue does not show a discussion between you and a maintainer.

To avoid wasted effort on both sides, please discuss your proposed approach in the issue first and wait for a maintainer to respond before opening a PR.

Please review our contributing guidelines for more details.

[szokeasaurusrex]

Sorry about the bot @mvanhorn, this PR indeed looks valid. I'll review when I have time.

In general, we like issues to be opened before PRs, but for simple stuff like this change, I think the issue is not necessarily needed.

Thanks again for your contribution!

[codecov]

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.36%. Comparing base (a57b91c) to head (0461562).
⚠️ Report is 81 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1074      +/-   ##
==========================================
+ Coverage   73.81%   74.36%   +0.55%     
==========================================
  Files          64       67       +3     
  Lines        7538     7942     +404     
==========================================
+ Hits         5564     5906     +342     
- Misses       1974     2036      +62     

[szokeasaurusrex]

Ok, just did a quick review; I am not sure whether we should do this at all, since it would break our public API.

Unless using PanicInfo is causing you some inconvenience, I would suggest we just keep the code as it is for now. Otherwise, perhaps it makes sense to open an issue to discuss the right approach after all 😅

If using PanicInfo is causing trouble for you, please open an issue to explain what the concrete problem is, and we can discuss a potential solution there.

[mvanhorn]

Thanks for the quick look @szokeasaurusrex. The PR body covers this but may have buried it - std defines pub type PanicInfo<'a> = PanicHookInfo<'a> (type alias, not a separate type), so downstream extractor closures using &PanicInfo<'_> continue to match the new &PanicHookInfo<'_> signatures on add_extractor / event_from_panic_info / message_from_panic_info. No break at the public-API boundary, just silences the six #[allow(deprecated)] annotations.

Happy to close if you'd still rather leave things as-is - the deprecation warning is cosmetic and the allow attrs aren't hurting anything. Just didn't want you to have to merge another six #[allow(deprecated)] reminders down the line.

[szokeasaurusrex]

Thanks for the explanation and for your patience. This looks good now!