feat(asyncpg): Add query source to execute, executemany, and cursor#6242
Open
ericapisani wants to merge 3 commits intopy-2305-migrate-asyncpgfrom
Open
feat(asyncpg): Add query source to execute, executemany, and cursor#6242ericapisani wants to merge 3 commits intopy-2305-migrate-asyncpgfrom
ericapisani wants to merge 3 commits intopy-2305-migrate-asyncpgfrom
Conversation
Add add_query_source() calls to execute(), executemany(), and cursor() methods. Previously only fetch() had query source tracking. Handle StreamedSpan and regular span cases separately since StreamedSpan requires the call while still inside the context manager. Add comprehensive test coverage for query source tracking across all wrapped methods.
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 8.90s All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 15167 uncovered lines. Files with missing lines (1)
Generated by Codecov Action |
…to-methods-that-were-missing-it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add_query_source()calls to_wrap_connection_methodand_wrap_cursor_creation, which coverexecute(),executemany(),prepare(), andcursor(). Previously onlyfetch()had query source tracking via the patched_wrap_executemethod.StreamedSpanvs regular span cases separately (StreamedSpan needs the call inside the context manager).