ref: remove universal bdist_wheel option#6138
Closed
juliosuas wants to merge 1 commit intogetsentry:masterfrom
Closed
ref: remove universal bdist_wheel option#6138juliosuas wants to merge 1 commit intogetsentry:masterfrom
juliosuas wants to merge 1 commit intogetsentry:masterfrom
Conversation
universal wheels were a python 2/3 thing. python 2 support is long gone (setup.py only declares 3.7+ classifiers) so the option is just dead config now. closes getsentry#6121
|
This PR has been automatically closed. The referenced issue does not show a discussion between you and a maintainer. To avoid wasted effort on both sides, please discuss your proposed approach in the issue first and wait for a maintainer to respond before opening a PR. Please review our contributing guidelines for more details. |
sdk-maintainer-bot
Bot
added
missing-maintainer-discussion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #6121.
universal wheels existed for the python 2/3 split — single
.whlthat worked on both runtimes. with python 2 long gone (setup.py only declares 3.7+ classifiers), thebdist_wheel.universal=1option is dead config. removing it.modern
pip wheel/buildworkflows produce per-runtime wheels by default, no extra flags needed.