fix(integrations): Remove asyncio iscoroutinefunction warning

[cooperoptigrid]

Description

Uses Django ASGI function patching to use inspect.iscoroutinefunction instead of asyncio.iscoroutinefunction to avoid depreaction warning in 3.14.
Rolled out to all uses of asyncio.iscoroutinefunction in the integrations package.

Repro in issue doesn't raise warning with these changes. tox linters and test pass on py3.12, py3.14.

Issues

• resolves: #6085

Reminders

• Please add tests to validate your changes, and lint your code using tox -e linters.
• Add GH Issue ID & Linear ID (if applicable)
• PR title should use conventional commit style (feat:, fix:, ref:, meta:)
• For external contributors: CONTRIBUTING.md, Sentry SDK development docs, Discord community

[sdk-maintainer-bot]

This PR has been automatically closed. The referenced issue is already assigned to someone else.

If you believe this assignment is outdated, please comment on the issue to discuss before opening a new PR.

Please review our contributing guidelines for more details.

[github-actions]

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

---

New Features ✨

• (ci) Cancel in-progress PR workflows on new commit push by joshuarli in #5994
• Add db.driver.name spans to database integrations by ericapisani in #6082

Bug Fixes 🐛

• (google_genai) Redact binary data in inline_data and fix multi-part message extraction by ericapisani in #5977
• (grpc) Add isolation_scope to async server interceptor by robinvd in #5940

• (integrations) Asyncio iscoroutinefunction warning by cooperoptigrid in #6090

• (profiler) Stop nulling buffer on teardown by ericapisani in #6075

Internal Changes 🔧

• (celery) Remove unused NoOpMgr from utils by sentrivana in #6078
• (ci) Update outdated pinned action version comments by JoshuaMoelans in #6088
• (pydantic-ai) Remove dead Model.request patch by alexander-alderman-webb in #5956
• (tests) Replace deprecated enable_tracingwith traces_sample_rate by sentrivana in #6077
• Set explicit base-branch for codecov action by ericapisani in #5992

---

_{🤖 This preview updates automatically when you update the PR.}

[alexander-alderman-webb]

inspect.iscoroutinefunction is not a drop-in replacement for asyncio.iscoroutinefunction on old Python versions (which we support).

There's some details in this blog post: https://lucumr.pocoo.org/2016/10/30/i-dont-understand-asyncio/

There's an existing PR containing some advice on approaching the migration. Generally mirroring the respective library's version checks would be great (not just copying Django's specific handling across the whole SDK)!

#4915

[alexander-alderman-webb]

_markcoroutinefunction is not used outside of the Django integration, so please leave it there.

[cooperoptigrid]

I've simply moved it back for this PR. Still digesting the other comment

[cooperoptigrid]

#4915

@alexander-alderman-webb Do you want me to take those changes from that PR and add those patches here and address any outstanding comments? Or were there fundamental issues blocking its merge, and I should take a different approach entirely.

[cooperoptigrid]

I've switched to using the PY313 check, as per the other comments. I've left all existing uses of inspect as-is. There are dozens of uses of asyncio.iscoroutinefunction in the tests/. I decided not to change them in this PR, to try and keep it focused, but happy to swap them directly to inspect

[alexander-alderman-webb]

Hi @cooperoptigrid.

I've taken care of the integrations now in #6133, #6134 and #6135.

TL;DR: to be on the safe side we want to mirror the library's handling, and it turns out that each library has a different version cut-off. We're taking this precaution because asyncio.iscoroutinefunction is unfortunately not the same as inspect.iscoroutinefunction when it comes to functions marked with _is_coroutine. You can run this script below to verify.

This is possibly quite rare but it's also easier for us to maintain 😅. The risk would be creating an async/sync wrapper for a function that is treated as sync/async in the library, which could cause a coroutine to never be awaited or a TypeError.

If you'd like, feel free to update the tests. You should be able to just convert the occurrences of asyncio.iscoroutinefunction to inspect.iscoroutinefunction in tests 🙏 .

import asyncio
import inspect

async def real_async_handler(request):
    return f"hello {request}"

def my_handler(request):
    return real_async_handler(request)

my_handler._is_coroutine = asyncio.coroutines._is_coroutine

print(f"inspect.iscoroutinefunction(my_handler): "
      f"{inspect.iscoroutinefunction(my_handler)}")
print(f"asyncio.iscoroutinefunction(my_handler): "
      f"{asyncio.iscoroutinefunction(my_handler)}")

[sentry]

Bug: The version check for asyncio.iscoroutinefunction deprecation is incorrect. It checks for Python 3.13+ (PY313) but the deprecation occurred in Python 3.12.
_{Severity: LOW}

Suggested Fix

Update the version check to target Python 3.12 instead of 3.13. This can be done by creating and using a PY312 constant or by reverting to the previous check hasattr(inspect, "markcoroutinefunction") which correctly identifies Python 3.12 and newer.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: sentry_sdk/integrations/_asgi_common.py#L20-L22

Potential issue: The code uses a version check for Python 3.13 (`PY313`) to decide
whether to use `inspect.iscoroutinefunction` instead of the deprecated
`asyncio.iscoroutinefunction`. However, `asyncio.iscoroutinefunction` was deprecated
starting in Python 3.12. Consequently, when running on Python 3.12, the code will still
use the deprecated function, generating a `DeprecationWarning`. This negates the
intended fix of the pull request, which was to remove this warning for supported Python
versions.

Also affects:

• sentry_sdk/_compat.py:16~16

_{Did we get this right? 👍 / 👎 to inform future reviews.}

[cooperoptigrid]

Thanks for those PRs @alexander-alderman-webb , makes sense now I see what you meant by mirroring the library’s approach!

I’ll change the scope of this PR to simply updating test code.